[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    D13284: [decorations] Let KDecoration plugins recommend a border size per default
From:       Roman Gilg <noreply () phabricator ! kde ! org>
Date:       2018-06-02 12:52:27
Message-ID: 20180602125227.1.6ABB7919426BECD0 () phabricator ! kde ! org
[Download RAW message or body]

romangg created this revision.
romangg added reviewers: KWin, Plasma, VDG.
Restricted Application added a project: KWin.
Restricted Application added a subscriber: kwin.
romangg requested review of this revision.

REVISION SUMMARY
  This is an alternative solution to T8707 <https://phabricator.kde.org/T8707> and in \
comparision to D13276 <https://phabricator.kde.org/D13276> a less  drastic change to \
KWin's default behavior.  
  Instead of changing the border size default for all KDecoration plugins by
  switching the default from border size Normal to None introduce new
  functionality, which allows a KDecoration plugin to recommend a border size in
  its metadata. By default KWin listens for these recommendations and sets the
  border size accordingly.
  
  If there is no metadata recommending a border size, KWin falls back to the
  current setting of Normal sized borders.
  
  A user is able to override the recommendations from the KCM, which has been
  extended accordingly.

TEST PLAN
  Manually with adjusted metadata of Breeze.

REPOSITORY
  R108 KWin

BRANCH
  borderSizeRecommend

REVISION DETAIL
  https://phabricator.kde.org/D13284

AFFECTED FILES
  decorations/decorationbridge.cpp
  decorations/decorationbridge.h
  decorations/settings.cpp
  decorations/settings.h
  kcmkwin/kwindecoration/kcm.cpp
  kcmkwin/kwindecoration/kcm.ui

To: romangg, #kwin, #plasma, #vdg
Cc: kwin, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, lesliezhai, \
ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart


[Attachment #3 (unknown)]

<table><tr><td style="">romangg created this revision.<br />romangg added reviewers: \
KWin, Plasma, VDG.<br />Restricted Application added a project: KWin.<br />Restricted \
Application added a subscriber: kwin.<br />romangg requested review of this revision. \
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D13284">View Revision</a></tr></table><br \
/><div><strong>REVISION SUMMARY</strong><div><p>This is an alternative solution to <a \
href="https://phabricator.kde.org/T8707" style="background-color: #e7e7e7;  \
border-color: #e7e7e7;  border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: none;">T8707</a> and in comparision to <a \
href="https://phabricator.kde.org/D13276" style="background-color: #e7e7e7;  \
border-color: #e7e7e7;  border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: none;">D13276</a> a less<br />
drastic change to KWin&#039;s default behavior.</p>

<p>Instead of changing the border size default for all KDecoration plugins by<br />
switching the default from border size Normal to None introduce new<br />
functionality, which allows a KDecoration plugin to recommend a border size in<br />
its metadata. By default KWin listens for these recommendations and sets the<br />
border size accordingly.</p>

<p>If there is no metadata recommending a border size, KWin falls back to the<br />
current setting of Normal sized borders.</p>

<p>A user is able to override the recommendations from the KCM, which has been<br />
extended accordingly.</p></div></div><br /><div><strong>TEST \
PLAN</strong><div><p>Manually with adjusted metadata of Breeze.</p></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R108 KWin</div></div></div><br \
/><div><strong>BRANCH</strong><div><div>borderSizeRecommend</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D13284">https://phabricator.kde.org/D13284</a></div></div><br \
/><div><strong>AFFECTED FILES</strong><div><div>decorations/decorationbridge.cpp<br \
/> decorations/decorationbridge.h<br />
decorations/settings.cpp<br />
decorations/settings.h<br />
kcmkwin/kwindecoration/kcm.cpp<br />
kcmkwin/kwindecoration/kcm.ui</div></div></div><br /><div><strong>To: \
</strong>romangg, KWin, Plasma, VDG<br /><strong>Cc: </strong>kwin, ragreen, \
jackyalcine, Pitel, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, hardening, \
jensreuterberg, abetts, sebas, apol, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]