[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    D1230: GBM remote access support for KWin
From:       Roman Gilg <noreply () phabricator ! kde ! org>
Date:       2018-03-21 10:10:28
Message-ID: 20180321101028.1.B2FF1C2FC634093F () phabricator ! kde ! org
[Download RAW message or body]

romangg added a comment.


  In D1230#230613 <https://phabricator.kde.org/D1230#230613>, @Kanedias wrote:
  
  > They don't override anything and compile fails for me if they are present. GCC \
7.3.1.  
  
  I believe this is an unrelated regression you just ran into because of D11209 \
<https://phabricator.kde.org/D11209>. I hadn't yet updated my KDecoration clone, \
that's why it still compiled for me. In any case please remove the unrelated override \
keyword removal from the patch and let's hope the regression will be quickly fixed in \
KDecoration.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D1230

To: Kanedias, graesslin, davidedmundson, romangg, #kwin
Cc: jgrulich, romangg, ngraham, alexeymin, aacid, kwin, #kwin, davidedmundson, \
plasma-devel, schernikov, iodelay, zzag, bwowk, ZrenBot, lesliezhai, ali-mohamed, \
hardening, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein


[Attachment #3 (unknown)]

<table><tr><td style="">romangg added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D1230">View Revision</a></tr></table><br \
/><div><div><blockquote style="border-left: 3px solid #8C98B8;  color: #6B748C;
          font-style: italic;
          margin: 4px 0 12px 0;
          padding: 8px 12px;
          background-color: #F8F9FC;">
<div style="font-style: normal;
          padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D1230#230613" \
style="background-color: #e7e7e7;  border-color: #e7e7e7;
          border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: none;">D1230#230613</a>, <a \
href="https://phabricator.kde.org/p/Kanedias/" style="  border-color: #f1f7ff;
              color: #19558d;
              background-color: #f1f7ff;
                border: 1px solid transparent;
                border-radius: 3px;
                font-weight: bold;
                padding: 0 4px;">@Kanedias</a> wrote:</div>
<div style="margin: 0;
          padding: 0;
          border: 0;
          color: rgb(107, 116, 140);"><p>They don&#039;t override anything and \
compile fails for me if they are present. GCC 7.3.1.</p></div> </blockquote>

<p>I believe this is an unrelated regression you just ran into because of <a \
href="https://phabricator.kde.org/D11209" style="background-color: #e7e7e7;  \
border-color: #e7e7e7;  border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: line-through;">D11209</a>. I hadn&#039;t yet \
updated my KDecoration clone, that&#039;s why it still compiled for me. In any case \
please remove the unrelated override keyword removal from the patch and let&#039;s \
hope the regression will be quickly fixed in KDecoration.</p></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R108 KWin</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D1230">https://phabricator.kde.org/D1230</a></div></div><br \
/><div><strong>To: </strong>Kanedias, graesslin, davidedmundson, romangg, KWin<br \
/><strong>Cc: </strong>jgrulich, romangg, ngraham, alexeymin, aacid, kwin, KWin, \
davidedmundson, plasma-devel, schernikov, iodelay, zzag, bwowk, ZrenBot, lesliezhai, \
ali-mohamed, hardening, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein<br \
/></div>



[prev in list] [next in list] [prev in thread] [next in thread]