[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    D9516: [libinput] Add support for switch devices and events
From:       Roman Gilg <noreply () phabricator ! kde ! org>
Date:       2018-01-04 8:35:41
Message-ID: 20180104083541.1.087F578CEB51996E () phabricator ! kde ! org
[Download RAW message or body]

romangg accepted this revision.
romangg added a comment.
This revision is now accepted and ready to land.
Restricted Application edited projects, added Plasma; removed KWin.


  Code looks good to me. At the moment there is nothing to test anyway, right?
  
  FYI Martin if you want to build libinput in the future on Neon, then you need \
besides the stuff linked by @ngraham the GNOME Staging PPA \
<https://launchpad.net/~gnome3-team/+archive/ubuntu/gnome3-staging> since there is a \
GTK3 dependency. I was also able some time ago to disable building lbinput with its \
debug console (which needs the GTK3 stuff) so I didn't need the PPA, but with the \
current meson version I wasn't able to, so I got the PPA and added the following file \
to `etc/apt/preferences.d/gnome3-team-gnome3-staging` (then it only updates the \
listed four packages from the PPA):  
    Package: *
    Pin: release o=LP-PPA-gnome3-team-gnome3-staging
    Pin-Priority: -1
    
    Package: libgtk-3-dev
    Pin: release o=LP-PPA-gnome3-team-gnome3-staging
    Pin-Priority: 500
    
    Package: libgtk-3-common
    Pin: release o=LP-PPA-gnome3-team-gnome3-staging
    Pin-Priority: 500
    
    Package: libgtk-3-0
    Pin: release o=LP-PPA-gnome3-team-gnome3-staging
    Pin-Priority: 500
    
    Package: gir1.2-gtk-3.0
    Pin: release o=LP-PPA-gnome3-team-gnome3-staging
    Pin-Priority: 500

REPOSITORY
  R108 KWin

BRANCH
  libinput-switch

REVISION DETAIL
  https://phabricator.kde.org/D9516

To: graesslin, #kwin, #plasma, romangg
Cc: romangg, ngraham, plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, \
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart


[Attachment #3 (unknown)]

<table><tr><td style="">romangg accepted this revision.<br />romangg added a \
comment.<br />This revision is now accepted and ready to land.<br />Restricted \
Application edited projects, added Plasma; removed KWin. </td><a \
style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; \
color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; \
background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; \
border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D9516" \
rel="noreferrer">View Revision</a></tr></table><br /><div><div><p>Code looks good to \
me. At the moment there is nothing to test anyway, right?</p>

<p>FYI Martin if you want to build libinput in the future on Neon, then you need \
besides the stuff linked by <a href="https://phabricator.kde.org/p/ngraham/" style="  \
border-color: #f1f7ff;  color: #19558d;
              background-color: #f1f7ff;
                border: 1px solid transparent;
                border-radius: 3px;
                font-weight: bold;
                padding: 0 4px;" rel="noreferrer">@ngraham</a> the <a \
href="https://launchpad.net/~gnome3-team/+archive/ubuntu/gnome3-staging" \
class="remarkup-link" target="_blank" rel="noreferrer">GNOME Staging PPA</a> since \
there is a GTK3 dependency. I was also able some time ago to disable building lbinput \
with its debug console (which needs the GTK3 stuff) so I didn&#039;t need the PPA, \
but with the current meson version I wasn&#039;t able to, so I got the PPA and added \
the following file to <tt style="background: #ebebeb; font-size: \
13px;">etc/apt/preferences.d/gnome3-team-gnome3-staging</tt> (then it only updates \
the listed four packages from the PPA):</p>

<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" \
data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px \
&quot;Menlo&quot;, &quot;Consolas&quot;, &quot;Monaco&quot;, monospace; padding: \
                12px; margin: 0; background: rgba(71, 87, 120, 0.08);">Package: *
Pin: release o=LP-PPA-gnome3-team-gnome3-staging
Pin-Priority: -1

Package: libgtk-3-dev
Pin: release o=LP-PPA-gnome3-team-gnome3-staging
Pin-Priority: 500

Package: libgtk-3-common
Pin: release o=LP-PPA-gnome3-team-gnome3-staging
Pin-Priority: 500

Package: libgtk-3-0
Pin: release o=LP-PPA-gnome3-team-gnome3-staging
Pin-Priority: 500

Package: gir1.2-gtk-3.0
Pin: release o=LP-PPA-gnome3-team-gnome3-staging
Pin-Priority: 500</pre></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R108 KWin</div></div></div><br \
/><div><strong>BRANCH</strong><div><div>libinput-switch</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D9516" \
rel="noreferrer">https://phabricator.kde.org/D9516</a></div></div><br \
/><div><strong>To: </strong>graesslin, KWin, Plasma, romangg<br /><strong>Cc: \
</strong>romangg, ngraham, plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, \
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]