[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    D9391: [effects] Add 'Fullscreen' effect
From:       Vlad Zagorodniy <noreply () phabricator ! kde ! org>
Date:       2017-12-31 16:20:49
Message-ID: 20171231162049.1.9692074110E91739 () phabricator ! kde ! org
[Download RAW message or body]

zzag added a comment.
Restricted Application edited projects, added Plasma; removed KWin.


  In https://phabricator.kde.org/D9391#182439, @graesslin wrote:
  
  > I'm absolutely against any changed to window gravity on X11. And I'm also not \
happy with a new animation if we already know that it doesn't work correctly.  
  
  I don't like changing window gravity code either.
  
  > Given that 5.12 will be an LTS this might be unpleasant.
  
  Yeah, it should be at least 5.13
  
  > Due to that I personally would prefer if we don't add this for 5.12 or only for \
Wayland windows.  
  Is it okay to support only Wayland?

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D9391

To: zzag, #kwin, #plasma, graesslin
Cc: graesslin, broulik, plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, \
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart


[Attachment #3 (unknown)]

<table><tr><td style="">zzag added a comment.<br />Restricted Application edited \
projects, added Plasma; removed KWin. </td><a style="text-decoration: none; padding: \
4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; \
border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to \
bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D9391" rel="noreferrer">View \
Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid \
#8C98B8;  color: #6B748C;
          font-style: italic;
          margin: 4px 0 12px 0;
          padding: 8px 12px;
          background-color: #F8F9FC;">
<div style="font-style: normal;
          padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D9391#182439" \
style="background-color: #e7e7e7;  border-color: #e7e7e7;
          border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: none;" rel="noreferrer">D9391#182439</a>, <a \
href="https://phabricator.kde.org/p/graesslin/" style="  border-color: #f1f7ff;
              color: #19558d;
              background-color: #f1f7ff;
                border: 1px solid transparent;
                border-radius: 3px;
                font-weight: bold;
                padding: 0 4px;" rel="noreferrer">@graesslin</a> wrote:</div>
<div style="margin: 0;
          padding: 0;
          border: 0;
          color: rgb(107, 116, 140);"><p>I&#039;m absolutely against any changed to \
window gravity on X11. And I&#039;m also not happy with a new animation if we already \
know that it doesn&#039;t work correctly.</p></div> </blockquote>

<p>I don&#039;t like changing window gravity code either.</p>

<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: \
italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>Given \
that 5.12 will be an LTS this might be unpleasant.</p></blockquote>

<p>Yeah, it should be at least 5.13</p>

<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: \
italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>Due \
to that I personally would prefer if we don&#039;t add this for 5.12 or only for \
Wayland windows.</p></blockquote>

<p>Is it okay to support only Wayland?</p></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R108 KWin</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D9391" \
rel="noreferrer">https://phabricator.kde.org/D9391</a></div></div><br \
/><div><strong>To: </strong>zzag, KWin, Plasma, graesslin<br /><strong>Cc: \
</strong>graesslin, broulik, plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, \
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]