[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: D9487: [effects/slide] Handle moving clients
From: Martin_Flöser <noreply () phabricator ! kde ! org>
Date: 2017-12-23 14:42:45
Message-ID: 20171223144245.40877.DDF9A195AC055D42 () phabricator ! kde ! org
[Download RAW message or body]
graesslin requested changes to this revision.
graesslin added inline comments.
This revision now requires changes to proceed.
Restricted Application edited projects, added KWin; removed Plasma.
INLINE COMMENTS
> slide.cpp:93-94
> }
> + } else if (w == m_movingWindow) {
> + // A window which is being moved is always inside our viewport, do \
> nothing. } else if (w->isOnDesktop(painting_desktop)) {
I don't like empty if blocks. Please handle this e.g. with if (slide && w != \
m_movingWindow)
> slide.cpp:282
> +
> + m_movingWindow = with;
> +
The window is nowhere reset, also it's not handling the windowClosed/windowRemoved \
case. This means the pointer could dangle.
> slide.h:67
> QPoint slide_painting_diff;
> + EffectWindow* m_movingWindow;
>
You can simplify:
EffectWindow *m_movingWindow = nullptr;
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D9487
To: zzag, #kwin, #plasma, graesslin
Cc: graesslin, plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai, \
ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart
[Attachment #3 (unknown)]
<table><tr><td style="">graesslin requested changes to this revision.<br />graesslin \
added inline comments.<br />This revision now requires changes to proceed.<br \
/>Restricted Application edited projects, added KWin; removed Plasma. </td><a \
style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; \
color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; \
background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; \
border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D9487" \
rel="noreferrer">View Revision</a></tr></table><br /><div><strong>INLINE \
COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px \
solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; \
border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div \
style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a \
style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D9487#inline-43012" rel="noreferrer">View \
Inline</a><span style="color: #4b4d51; font-weight: \
bold;">slide.cpp:93-94</span></div> <div style="font: 11px/15px "Menlo", \
"Consolas", "Monaco", monospace; white-space: pre-wrap; clear: \
both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> \
<span class="p">}</span> </div><div style="padding: 0 8px; margin: 0 4px; background: \
rgba(151, 234, 151, .6);"> <span class="p">}</span> <span style="color: \
#aa4000">else</span> <span style="color: #aa4000">if</span> <span \
class="p">(</span><span class="n">w</span> <span style="color: #aa2211">==</span> \
<span class="n">m_movingWindow</span><span class="p">)</span> <span \
class="p">{</span> </div><div style="padding: 0 8px; margin: 0 4px; background: \
rgba(151, 234, 151, .6);"> <span style="color: #74777d">// A window which \
is being moved is always inside our viewport, do nothing.</span> </div><div \
style="padding: 0 8px; margin: 0 4px; "> <span class="p">}</span> <span \
style="color: #aa4000">else</span> <span style="color: #aa4000">if</span> <span \
class="p">(</span><span class="n">w</span><span style="color: \
#aa2211">-></span><span class="n">isOnDesktop</span><span class="p">(</span><span \
class="n">painting_desktop</span><span class="p">))</span> <span class="p">{</span> \
</div></div></div> <div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; \
margin: 8px;">I don't like empty if blocks. Please handle this e.g. with if \
(slide && w != m_movingWindow)</p></div></div><br /><div style="border: 1px \
solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; \
border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div \
style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a \
style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D9487#inline-43013" rel="noreferrer">View \
Inline</a><span style="color: #4b4d51; font-weight: bold;">slide.cpp:282</span></div> \
<div style="font: 11px/15px "Menlo", "Consolas", \
"Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; \
margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, \
151, .6);"> <span class="n">m_movingWindow</span> <span style="color: \
#aa2211">=</span> <span class="n">with</span><span class="p">;</span> \
</div></div></div> <div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; \
margin: 8px;">The window is nowhere reset, also it's not handling the \
windowClosed/windowRemoved case. This means the pointer could \
dangle.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: \
3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; \
border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; \
background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; \
text-decoration: none;" href="https://phabricator.kde.org/D9487#inline-43011" \
rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: \
bold;">slide.h:67</span></div> <div style="font: 11px/15px "Menlo", \
"Consolas", "Monaco", monospace; white-space: pre-wrap; clear: \
both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> \
<span class="n">QPoint</span> <span class="n">slide_painting_diff</span><span \
class="p">;</span> </div><div style="padding: 0 8px; margin: 0 4px; background: \
rgba(151, 234, 151, .6);"> <span class="n">EffectWindow</span><span style="color: \
#aa2211">*</span> <span class="n">m_movingWindow</span><span class="p">;</span> \
</div></div></div> <div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; \
margin: 8px;">You can simplify:</p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" \
data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px \
"Menlo", "Consolas", "Monaco", monospace; padding: \
12px; margin: 0; background: rgba(71, 87, 120, 0.08);">EffectWindow *m_movingWindow = \
nullptr;</pre></div></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R108 KWin</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D9487" \
rel="noreferrer">https://phabricator.kde.org/D9487</a></div></div><br \
/><div><strong>To: </strong>zzag, KWin, Plasma, graesslin<br /><strong>Cc: \
</strong>graesslin, plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai, \
ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart<br /></div>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic