[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    D8582: [platforms/drm] Add support for rotation property on the Plane
From:       David Edmundson <noreply () phabricator ! kde ! org>
Date:       2017-10-31 19:04:00
Message-ID: 20171031190356.104865.D671CA9842C2F7BA () phabricator ! kde ! org
[Download RAW message or body]

davidedmundson added a comment.


  Do you think we'll need a compositor fallback?
  
  *If* we do have a compositor fallback, then I don't see the point of a DRM specific \
codepath, it's not going to have any slower having a transform in painting, and will \
just result in one code path not getting tested.  
  To mostly answer my own question:
  
  In hwcomposer, it seems we have a transform attribute on the layer.
  
  For nested wayland we can set a transform on our wl_surface.
  
  For FBDev or nested in X, I don't think we can. But probably don't care?

INLINE COMMENTS

> drm_object_plane.h:63
> +    enum class Rotation {
> +        Rotate0 = 1 << 0,
> +        Rotate90 = 1 << 1,

why don't we use DRM_MODE_ROTATE_0 for the values?

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D8582

To: graesslin, #kwin, #plasma, subdiff
Cc: davidedmundson, plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai, \
ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart


[Attachment #3 (unknown)]

<table><tr><td style="">davidedmundson added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D8582" rel="noreferrer">View \
Revision</a></tr></table><br /><div><div><p>Do you think we&#039;ll need a compositor \
fallback?</p>

<p>*If* we do have a compositor fallback, then I don&#039;t see the point of a DRM \
specific codepath, it&#039;s not going to have any slower having a transform in \
painting, and will just result in one code path not getting tested.</p>

<p>To mostly answer my own question:</p>

<p>In hwcomposer, it seems we have a transform attribute on the layer.</p>

<p>For nested wayland we can set a transform on our wl_surface.</p>

<p>For FBDev or nested in X, I don&#039;t think we can. But probably don&#039;t \
care?</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div \
style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: \
3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; \
border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; \
background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; \
text-decoration: none;" href="https://phabricator.kde.org/D8582#inline-37375" \
rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: \
bold;">drm_object_plane.h:63</span></div> <div style="font: 11px/15px \
&quot;Menlo&quot;, &quot;Consolas&quot;, &quot;Monaco&quot;, monospace; white-space: \
pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; \
margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: \
#aa4000">enum</span> <span class="n">class</span> <span class="n">Rotation</span> \
<span class="p">{</span> </div><div style="padding: 0 8px; margin: 0 4px; background: \
rgba(151, 234, 151, .6);">        <span class="n">Rotate0</span> <span style="color: \
#aa2211">=</span> <span style="color: #601200">1</span> <span style="color: \
#aa2211">&lt;&lt;</span> <span style="color: #601200">0</span><span \
class="p">,</span> </div><div style="padding: 0 8px; margin: 0 4px; background: \
rgba(151, 234, 151, .6);">        <span class="n">Rotate90</span> <span style="color: \
#aa2211">=</span> <span style="color: #601200">1</span> <span style="color: \
#aa2211">&lt;&lt;</span> <span style="color: #601200">1</span><span \
class="p">,</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">why \
don&#039;t we use DRM_MODE_ROTATE_0 for the \
values?</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R108 KWin</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D8582" \
rel="noreferrer">https://phabricator.kde.org/D8582</a></div></div><br \
/><div><strong>To: </strong>graesslin, KWin, Plasma, subdiff<br /><strong>Cc: \
</strong>davidedmundson, plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai, \
ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]