[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    D8398: [drm] Implement changing of modes
From:       Roman Gilg <noreply () phabricator ! kde ! org>
Date:       2017-10-21 20:11:34
Message-ID: 20171021201134.62369.B0FE6CD22C756EC8 () phabricator ! kde ! org
[Download RAW message or body]

subdiff accepted this revision.
subdiff added a comment.
This revision is now accepted and ready to land.


  Looks good to me. I couldn't test it though, because KScreen KCM only showed me one \
mode to select from.

INLINE COMMENTS

> drm_output.h:152
> drmModeModeInfo m_mode;
> +    drmModeModeInfo m_previousMode;
> Edid m_edid;

Nowhere (yet?) used.

REPOSITORY
  R108 KWin

BRANCH
  drm-mode-changes

REVISION DETAIL
  https://phabricator.kde.org/D8398

To: graesslin, #kwin, #plasma, subdiff, sebas
Cc: plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, \
abetts, sebas, apol, mart


[Attachment #3 (unknown)]

<table><tr><td style="">subdiff accepted this revision.<br />subdiff added a \
comment.<br />This revision is now accepted and ready to land. </td><a \
style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; \
color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; \
background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; \
border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D8398" \
rel="noreferrer">View Revision</a></tr></table><br /><div><div><p>Looks good to me. I \
couldn&#039;t test it though, because KScreen KCM only showed me one mode to select \
from.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div \
style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: \
3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; \
border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; \
background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; \
text-decoration: none;" href="https://phabricator.kde.org/D8398#inline-35786" \
rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: \
bold;">drm_output.h:152</span></div> <div style="font: 11px/15px &quot;Menlo&quot;, \
&quot;Consolas&quot;, &quot;Monaco&quot;, monospace; white-space: pre-wrap; clear: \
both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">    \
<span class="n">drmModeModeInfo</span> <span class="n">m_mode</span><span \
class="p">;</span> </div><div style="padding: 0 8px; margin: 0 4px; background: \
rgba(151, 234, 151, .6);">    <span class="n">drmModeModeInfo</span> <span \
class="n">m_previousMode</span><span class="p">;</span> </div><div style="padding: 0 \
8px; margin: 0 4px; ">    <span class="n">Edid</span> <span \
class="n">m_edid</span><span class="p">;</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: \
8px;">Nowhere (yet?) used.</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R108 KWin</div></div></div><br \
/><div><strong>BRANCH</strong><div><div>drm-mode-changes</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D8398" \
rel="noreferrer">https://phabricator.kde.org/D8398</a></div></div><br \
/><div><strong>To: </strong>graesslin, KWin, Plasma, subdiff, sebas<br /><strong>Cc: \
</strong>plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas, apol, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]