[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    D8398: [drm] Implement changing of modes
From:       Roman Gilg <noreply () phabricator ! kde ! org>
Date:       2017-10-21 15:44:37
Message-ID: 20171021154437.45148.03B45BB322FBA720 () phabricator ! kde ! org
[Download RAW message or body]

subdiff added inline comments.

INLINE COMMENTS

> egl_gbm_backend.cpp:153
> 
> -void EglGbmBackend::createOutput(DrmOutput *drmOutput)
> +bool EglGbmBackend::initOutput(Output &o, DrmOutput *drmOutput)
> {

Rename this function `resetOutput` and put the destroy surface logic from the lambda \
function below in here? Would look cleaner I think.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D8398

To: graesslin, #kwin, #plasma, subdiff, sebas
Cc: plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed, \
hardening, jensreuterberg, abetts, sebas, apol, mart


[Attachment #3 (unknown)]

<table><tr><td style="">subdiff added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D8398" rel="noreferrer">View \
Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div \
style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: \
3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; \
border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; \
background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; \
text-decoration: none;" href="https://phabricator.kde.org/D8398#inline-35735" \
rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: \
bold;">egl_gbm_backend.cpp:153</span></div> <div style="font: 11px/15px \
&quot;Menlo&quot;, &quot;Consolas&quot;, &quot;Monaco&quot;, monospace; white-space: \
pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; \
margin: 0 4px; background: rgba(251, 175, 175, .7);"><span \
class="bright"></span><span style="color: #aa4000"><span \
class="bright">void</span></span> <span class="n">EglGbmBackend</span><span \
style="color: #aa2211">::<span class="bright"></span></span><span \
class="bright"></span><span class="n"><span \
class="bright">create</span>Output</span><span class="p">(</span><span \
class="n">DrmOutput</span> <span style="color: #aa2211">*</span><span \
class="n">drmOutput</span><span class="p">)</span> </div><div style="padding: 0 8px; \
margin: 0 4px; background: rgba(151, 234, 151, .6);"><span \
class="bright"></span><span style="color: #aa4000"><span \
class="bright">bool</span></span> <span class="n">EglGbmBackend</span><span \
style="color: #aa2211">::<span class="bright"></span></span><span \
class="bright"></span><span class="n"><span \
class="bright">init</span>Output</span><span class="p">(<span \
class="bright"></span></span><span class="bright"></span><span class="n"><span \
class="bright">Output</span></span><span class="bright"> </span><span style="color: \
#aa2211"><span class="bright">&amp;</span></span><span class="bright"></span><span \
class="n"><span class="bright">o</span></span><span class="bright"></span><span \
class="p"><span class="bright">,</span></span><span class="bright"> </span><span \
class="n">DrmOutput</span> <span style="color: #aa2211">*</span><span \
class="n">drmOutput</span><span class="p">)</span> </div><div style="padding: 0 8px; \
margin: 0 4px; "><span class="p">{</span> </div><div style="padding: 0 8px; margin: 0 \
4px; background: rgba(251, 175, 175, .7);">    <span class="n">Output</span> <span \
class="n">o</span><span class="p">;</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: \
8px;">Rename this function <tt style="background: #ebebeb; font-size: \
13px;">resetOutput</tt> and put the destroy surface logic from the lambda function \
below in here? Would look cleaner I think.</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R108 KWin</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D8398" \
rel="noreferrer">https://phabricator.kde.org/D8398</a></div></div><br \
/><div><strong>To: </strong>graesslin, KWin, Plasma, subdiff, sebas<br /><strong>Cc: \
</strong>plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed, \
hardening, jensreuterberg, abetts, sebas, apol, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]