[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    D8163: Move StatusNotifierItem for VirtualKeyboard into a helper process
From:       Martin_Flöser <noreply () phabricator ! kde ! org>
Date:       2017-10-06 19:29:44
Message-ID: differential-rev-PHID-DREV-vuucafdclhglxawijjon-req () phabricator ! kde ! org
[Download RAW message or body]

graesslin created this revision.
graesslin added reviewers: KWin, Plasma, mart.
Restricted Application added a project: KWin.
Restricted Application added subscribers: kwin, plasma-devel.

REVISION SUMMARY
  During startup the StatusNotifierItem can cause a freeze as it might do
  a blocking DBus call while the other side is performing a Wayland
  roundtrip. This freeze is broken when the DBus call times out but then
  the SNI doesn't work either.
  
  By moving the SNI into a dedicated helper process KWin itself does not
  have any blocking calls to DBus. In addition KWin exposes a DBus API to
  enable/disable the virtual keyboard, so that other processes can also
  make use of it to provide e.g. a better UI (e.g. Plasmoid).
  
  BUG: 385371

TEST PLAN
  Started a new session, it did not freeze and I had a SNI which
  worked as expected

REPOSITORY
  R108 KWin

BRANCH
  virt-keyboard-sni

REVISION DETAIL
  https://phabricator.kde.org/D8163

AFFECTED FILES
  CMakeLists.txt
  autotests/CMakeLists.txt
  autotests/test_virtualkeyboard_dbus.cpp
  config-kwin.h.cmake
  helpers/CMakeLists.txt
  helpers/virtualkeyboard/CMakeLists.txt
  helpers/virtualkeyboard/main.cpp
  helpers/virtualkeyboard/sni.cpp
  helpers/virtualkeyboard/sni.h
  virtualkeyboard.cpp
  virtualkeyboard.h
  virtualkeyboard_dbus.cpp
  virtualkeyboard_dbus.h

To: graesslin, #kwin, #plasma, mart
Cc: plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed, \
hardening, jensreuterberg, abetts, sebas, apol, mart


[Attachment #3 (unknown)]

<table><tr><td style="">graesslin created this revision.<br />graesslin added \
reviewers: KWin, Plasma, mart.<br />Restricted Application added a project: KWin.<br \
/>Restricted Application added subscribers: kwin, plasma-devel. </td><a \
style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; \
color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; \
background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; \
border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D8163" \
rel="noreferrer">View Revision</a></tr></table><br /><div><strong>REVISION \
SUMMARY</strong><div><p>During startup the StatusNotifierItem can cause a freeze as \
it might do<br /> a blocking DBus call while the other side is performing a \
Wayland<br /> roundtrip. This freeze is broken when the DBus call times out but \
then<br /> the SNI doesn&#039;t work either.</p>

<p>By moving the SNI into a dedicated helper process KWin itself does not<br />
have any blocking calls to DBus. In addition KWin exposes a DBus API to<br />
enable/disable the virtual keyboard, so that other processes can also<br />
make use of it to provide e.g. a better UI (e.g. Plasmoid).</p>

<p>BUG: 385371</p></div></div><br /><div><strong>TEST PLAN</strong><div><p>Started a \
new session, it did not freeze and I had a SNI which<br /> worked as \
expected</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R108 \
KWin</div></div></div><br \
/><div><strong>BRANCH</strong><div><div>virt-keyboard-sni</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D8163" \
rel="noreferrer">https://phabricator.kde.org/D8163</a></div></div><br \
/><div><strong>AFFECTED FILES</strong><div><div>CMakeLists.txt<br /> \
autotests/CMakeLists.txt<br /> autotests/test_virtualkeyboard_dbus.cpp<br />
config-kwin.h.cmake<br />
helpers/CMakeLists.txt<br />
helpers/virtualkeyboard/CMakeLists.txt<br />
helpers/virtualkeyboard/main.cpp<br />
helpers/virtualkeyboard/sni.cpp<br />
helpers/virtualkeyboard/sni.h<br />
virtualkeyboard.cpp<br />
virtualkeyboard.h<br />
virtualkeyboard_dbus.cpp<br />
virtualkeyboard_dbus.h</div></div></div><br /><div><strong>To: </strong>graesslin, \
KWin, Plasma, mart<br /><strong>Cc: </strong>plasma-devel, kwin, bwowk, ZrenBot, \
progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, \
mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]