[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    D8039: Support software QtQuickRendering in Aurorae
From:       Aleix Pol Gonzalez <noreply () phabricator ! kde ! org>
Date:       2017-09-28 19:21:52
Message-ID: 20170928192138.35168.CBD335805BCE94E1 () phabricator ! kde ! org
[Download RAW message or body]

apol added inline comments.

INLINE COMMENTS

> aurorae.cpp:344
> 
> +        //workaround for https://codereview.qt-project.org/#/c/207198/
> +        m_renderControl->sync();

`#if QT_VERSION < QT_VERSION_CHECK(5,10,0)`?

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D8039

To: davidedmundson, #plasma
Cc: apol, plasma-devel, kwin, #kwin, bwowk, ZrenBot, progwolff, lesliezhai, \
ali-mohamed, hardening, jensreuterberg, abetts, sebas, mart


[Attachment #3 (unknown)]

<table><tr><td style="">apol added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D8039" rel="noreferrer">View \
Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div \
style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: \
3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; \
border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; \
background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; \
text-decoration: none;" href="https://phabricator.kde.org/D8039#inline-33429" \
rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: \
bold;">aurorae.cpp:344</span></div> <div style="font: 11px/15px &quot;Menlo&quot;, \
&quot;Consolas&quot;, &quot;Monaco&quot;, monospace; white-space: pre-wrap; clear: \
both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; \
background: rgba(151, 234, 151, .6);">        <span style="color: \
#74777d">//workaround for https://codereview.qt-project.org/#/c/207198/</span> \
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, \
.6);">        <span class="n">m_renderControl</span><span style="color: \
#aa2211">-&gt;</span><span class="n">sync</span><span class="p">();</span> \
</div></div></div> <div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; \
margin: 8px;"><tt style="background: #ebebeb; font-size: 13px;">#if QT_VERSION &lt; \
QT_VERSION_CHECK(5,10,0)</tt>?</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R108 KWin</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D8039" \
rel="noreferrer">https://phabricator.kde.org/D8039</a></div></div><br \
/><div><strong>To: </strong>davidedmundson, Plasma<br /><strong>Cc: </strong>apol, \
plasma-devel, kwin, KWin, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed, \
hardening, jensreuterberg, abetts, sebas, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]