[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    D7937: Don't reload background contrast effect on screen resize
From:       David Edmundson <noreply () phabricator ! kde ! org>
Date:       2017-09-22 13:14:16
Message-ID: differential-rev-PHID-DREV-njsdfutjp7a5j52ohcpg-req () phabricator ! kde ! org
[Download RAW message or body]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: KWin.
Restricted Application added subscribers: KWin, kwin, plasma-devel.

REVISION SUMMARY
  Similar to the Blur patch. Arguably rven less reason as this doesn't
  have a texture the size of the workspace.
  
  We don't need to delete and recreate the entire effect every time the
  screen changes; This deletes the wayland global which causes quite a bit
  of extra work for the clients.

TEST PLAN
  Changed resolution under X, and scale under wayland
  Panel looked the same and nothing exploded

REPOSITORY
  R108 KWin

BRANCH
  xdgv6

REVISION DETAIL
  https://phabricator.kde.org/D7937

AFFECTED FILES
  effects/backgroundcontrast/contrast.cpp

To: davidedmundson, #plasma
Cc: plasma-devel, kwin, #kwin, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed, \
hardening, jensreuterberg, abetts, sebas, apol, mart


[Attachment #3 (unknown)]

<table><tr><td style="">davidedmundson created this revision.<br />davidedmundson \
added a reviewer: Plasma.<br />Restricted Application added a project: KWin.<br \
/>Restricted Application added subscribers: KWin, kwin, plasma-devel. </td><a \
style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; \
color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; \
background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; \
border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D7937" \
rel="noreferrer">View Revision</a></tr></table><br /><div><strong>REVISION \
SUMMARY</strong><div><p>Similar to the Blur patch. Arguably rven less reason as this \
doesn&#039;t<br /> have a texture the size of the workspace.</p>

<p>We don&#039;t need to delete and recreate the entire effect every time the<br />
screen changes; This deletes the wayland global which causes quite a bit<br />
of extra work for the clients.</p></div></div><br /><div><strong>TEST \
PLAN</strong><div><p>Changed resolution under X, and scale under wayland<br /> Panel \
looked the same and nothing exploded</p></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R108 KWin</div></div></div><br \
/><div><strong>BRANCH</strong><div><div>xdgv6</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D7937" \
rel="noreferrer">https://phabricator.kde.org/D7937</a></div></div><br \
/><div><strong>AFFECTED \
FILES</strong><div><div>effects/backgroundcontrast/contrast.cpp</div></div></div><br \
/><div><strong>To: </strong>davidedmundson, Plasma<br /><strong>Cc: \
</strong>plasma-devel, kwin, KWin, bwowk, ZrenBot, progwolff, lesliezhai, \
ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]