[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    D6801: Replace delegate slots for window shortcut by std::bind expressions
From:       Martin_Flöser <noreply () phabricator ! kde ! org>
Date:       2017-07-20 17:10:36
Message-ID: differential-rev-PHID-DREV-tdcjq7q7n3fthkhrltfv-req () phabricator ! kde ! org
[Download RAW message or body]

graesslin created this revision.
Restricted Application added a project: KWin.
Restricted Application added subscribers: kwin, plasma-devel.

REVISION SUMMARY
  Client had a slot to delay a call when setting up a global shortcut for
  the Client. This can be simplified by using a std::bind expression.
  Similar the action was connected to a one line lambda which can be
  expressed through a std::bind expression as well.

TEST PLAN
  New added auto test still passes

REPOSITORY
  R108 KWin

BRANCH
  useractions-client-shortcut-simplify

REVISION DETAIL
  https://phabricator.kde.org/D6801

AFFECTED FILES
  client.h
  useractions.cpp

To: graesslin, #kwin, #plasma
Cc: plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, \
jensreuterberg, abetts, sebas, apol, mart, lukas


[Attachment #3 (unknown)]

<table><tr><td style="">graesslin created this revision.<br />Restricted Application \
added a project: KWin.<br />Restricted Application added subscribers: kwin, \
plasma-devel. </td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px \
8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; \
background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); \
display: inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D6801" rel="noreferrer">View \
Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>Client \
had a slot to delay a call when setting up a global shortcut for<br /> the Client. \
This can be simplified by using a std::bind expression.<br /> Similar the action was \
connected to a one line lambda which can be<br /> expressed through a std::bind \
expression as well.</p></div></div><br /><div><strong>TEST PLAN</strong><div><p>New \
added auto test still passes</p></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R108 KWin</div></div></div><br \
/><div><strong>BRANCH</strong><div><div>useractions-client-shortcut-simplify</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D6801" \
rel="noreferrer">https://phabricator.kde.org/D6801</a></div></div><br \
/><div><strong>AFFECTED FILES</strong><div><div>client.h<br /> \
useractions.cpp</div></div></div><br /><div><strong>To: </strong>graesslin, KWin, \
Plasma<br /><strong>Cc: </strong>plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, \
ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart, lukas<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]