[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    D6783: Replace Workspace::slotWindowQuickTileFoo by a quickTileWindow with argument
From:       Martin_Flöser <noreply () phabricator ! kde ! org>
Date:       2017-07-19 16:44:36
Message-ID: differential-rev-PHID-DREV-b6j4heeopeujyxt2jbee-req () phabricator ! kde ! org
[Download RAW message or body]

graesslin created this revision.
Restricted Application added a project: KWin.
Restricted Application added subscribers: kwin, plasma-devel.

REVISION SUMMARY
  Thanks to std::bind we don't need that many different slots to setup the
  global shortcut connections. Instead we can have one shared
  implementation which takes the argument and passes it to the window.
  
  To support std::bind arguments in kwinbindings the initShortcut method
  and dependencies are adjusted as well as a new macro is added.
  
  As I don't want to include abstract_client.h in workspace.h a new enum
  is created for the quick tiling flags used in Workspace. This caused a
  larger refactoring as the change to an enum class also caused quite some
  changes.

TEST PLAN
  Affected test cases still pass

REPOSITORY
  R108 KWin

BRANCH
  no-slot-window-quick-tile

REVISION DETAIL
  https://phabricator.kde.org/D6783

AFFECTED FILES
  abstract_client.cpp
  abstract_client.h
  autotests/integration/move_resize_window_test.cpp
  autotests/integration/quick_tiling_test.cpp
  client.cpp
  decorations/decoratedclient.cpp
  geometry.cpp
  input.h
  kwinbindings.cpp
  placement.cpp
  scripting/workspace_wrapper.cpp
  shell_client.cpp
  utils.h
  workspace.h

To: graesslin, #kwin, #plasma
Cc: plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, \
jensreuterberg, abetts, sebas, apol, mart, lukas


[Attachment #3 (unknown)]

<table><tr><td style="">graesslin created this revision.<br />Restricted Application \
added a project: KWin.<br />Restricted Application added subscribers: kwin, \
plasma-devel. </td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px \
8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; \
background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); \
display: inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D6783" rel="noreferrer">View \
Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>Thanks \
to std::bind we don&#039;t need that many different slots to setup the<br /> global \
shortcut connections. Instead we can have one shared<br /> implementation which takes \
the argument and passes it to the window.</p>

<p>To support std::bind arguments in kwinbindings the initShortcut method<br />
and dependencies are adjusted as well as a new macro is added.</p>

<p>As I don&#039;t want to include abstract_client.h in workspace.h a new enum<br />
is created for the quick tiling flags used in Workspace. This caused a<br />
larger refactoring as the change to an enum class also caused quite some<br />
changes.</p></div></div><br /><div><strong>TEST PLAN</strong><div><p>Affected test \
cases still pass</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R108 \
KWin</div></div></div><br \
/><div><strong>BRANCH</strong><div><div>no-slot-window-quick-tile</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D6783" \
rel="noreferrer">https://phabricator.kde.org/D6783</a></div></div><br \
/><div><strong>AFFECTED FILES</strong><div><div>abstract_client.cpp<br /> \
abstract_client.h<br /> autotests/integration/move_resize_window_test.cpp<br />
autotests/integration/quick_tiling_test.cpp<br />
client.cpp<br />
decorations/decoratedclient.cpp<br />
geometry.cpp<br />
input.h<br />
kwinbindings.cpp<br />
placement.cpp<br />
scripting/workspace_wrapper.cpp<br />
shell_client.cpp<br />
utils.h<br />
workspace.h</div></div></div><br /><div><strong>To: </strong>graesslin, KWin, \
Plasma<br /><strong>Cc: </strong>plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, \
ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart, lukas<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]