[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    D6420: Restore active client after ending showing desktop
From:       Kai Uwe Broulik <noreply () phabricator ! kde ! org>
Date:       2017-06-28 15:33:10
Message-ID: 20170628153246.86788.EA217B2018578179 () phabricator ! kde ! org
[Download RAW message or body]

broulik added inline comments.

INLINE COMMENTS

> showing_desktop_test.cpp:124
> +    QVERIFY(workspace()->activeClient());
> +    QEXPECT_FAIL("", "BUG...", Continue);
> +    QCOMPARE(workspace()->activeClient(), client2);

Is this intended?

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D6420

To: graesslin, #kwin, #plasma
Cc: broulik, plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, \
hardening, jensreuterberg, abetts, sebas, apol, mart, lukas


[Attachment #3 (unknown)]

<table><tr><td style="">broulik added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D6420" rel="noreferrer">View \
Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div \
style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: \
3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; \
border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; \
background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; \
text-decoration: none;" href="https://phabricator.kde.org/D6420#inline-26489" \
rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: \
bold;">showing_desktop_test.cpp:124</span></div> <div style="font: 11px/15px \
&quot;Menlo&quot;, &quot;Consolas&quot;, &quot;Monaco&quot;, monospace; white-space: \
pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; \
margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span \
class="n">QVERIFY</span><span class="p">(</span><span class="n">workspace</span><span \
class="p">()</span><span style="color: #aa2211">-&gt;</span><span \
class="n">activeClient</span><span class="p">());</span> </div><div style="padding: 0 \
8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span \
class="n">QEXPECT_FAIL</span><span class="p">(</span><span style="color: \
#766510">&quot;&quot;</span><span class="p">,</span> <span style="color: \
#766510">&quot;BUG...&quot;</span><span class="p">,</span> <span \
class="n">Continue</span><span class="p">);</span> </div><div style="padding: 0 8px; \
margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span \
class="n">QCOMPARE</span><span class="p">(</span><span \
class="n">workspace</span><span class="p">()</span><span style="color: \
#aa2211">-&gt;</span><span class="n">activeClient</span><span class="p">(),</span> \
<span class="n">client2</span><span class="p">);</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Is \
this intended?</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R108 KWin</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D6420" \
rel="noreferrer">https://phabricator.kde.org/D6420</a></div></div><br \
/><div><strong>To: </strong>graesslin, KWin, Plasma<br /><strong>Cc: \
</strong>broulik, plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, \
hardening, jensreuterberg, abetts, sebas, apol, mart, lukas<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]