[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    D5249: [RFC] New effect plugin - projector (keystone) correction
From:       Nicolás_Alvarez <noreply () phabricator ! kde ! org>
Date:       2017-04-12 4:38:44
Message-ID: 20170412043844.9963.78405.720D1F36 () phabricator ! kde ! org
[Download RAW message or body]

nalvarez added inline comments.

INLINE COMMENTS

> nowicki wrote in projector.cpp:101-126
> The reason for taking over cursor drawing is that when transformation is applied \
> the pointer pixmap doesn't match the point where the cursor actually hits the \
> windows below it. Since there is no way to apply translation to the HW cursor \
> position drawing a SW cursor is the only way to make the mouse usable with \
> tranformation applied.

I think it would be acceptable if the cursor is drawn just like it is now, on its own \
layer, even if drawing it without the transformation would make it slightly deformed \
visually.

You just have to ensure mouse //events// are properly inverse-transformed so that \
they go to the right place in the window. Isn't this already done for some effects? \
Isn't it possible to scale a window and keep interacting with it?

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D5249

To: nowicki, #plasma, graesslin
Cc: nalvarez, luebking, kwin, plasma-devel, #kwin, progwolff, lesliezhai, \
ali-mohamed, jensreuterberg, abetts, sebas, apol


[Attachment #3 (text/html)]

<table><tr><td style="">nalvarez added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D5249" rel="noreferrer">View \
Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div \
style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: \
3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; \
border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; \
background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; \
text-decoration: none;" href="https://phabricator.kde.org/D5249#inline-21616" \
rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: \
bold;">nowicki</span> wrote in <span style="color: #4b4d51; font-weight: \
bold;">projector.cpp:101-126</span></div> <div style="margin: 8px 0; padding: 0 12px; \
color: #74777D;"><p style="padding: 0; margin: 8px;">The reason for taking over \
cursor drawing is that when transformation is applied the pointer pixmap doesn&#039;t \
match the point where the cursor actually hits the windows below it. Since there is \
no way to apply translation to the HW cursor position drawing a SW cursor is the only \
way to make the mouse usable with tranformation applied.</p></div></div> <div \
style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">I think \
it would be acceptable if the cursor is drawn just like it is now, on its own layer, \
even if drawing it without the transformation would make it slightly deformed \
visually.</p>

<p style="padding: 0; margin: 8px;">You just have to ensure mouse <em>events</em> are \
properly inverse-transformed so that they go to the right place in the window. \
Isn&#039;t this already done for some effects? Isn&#039;t it possible to scale a \
window and keep interacting with it?</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R108 KWin</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D5249" \
rel="noreferrer">https://phabricator.kde.org/D5249</a></div></div><br \
/><div><strong>To: </strong>nowicki, Plasma, graesslin<br /><strong>Cc: \
</strong>nalvarez, luebking, kwin, plasma-devel, KWin, progwolff, lesliezhai, \
ali-mohamed, jensreuterberg, abetts, sebas, apol<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]