[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: D5245: Desaturate non-responsive windows
From: Kai Uwe Broulik <noreply () phabricator ! kde ! org>
Date: 2017-03-29 16:03:38
Message-ID: differential-rev-PHID-DREV-vy7bvprk6rp3lvm5izuv-req () phabricator ! kde ! org
[Download RAW message or body]
broulik created this revision.
Restricted Application added a project: KWin.
Restricted Application added subscribers: kwin, plasma-devel.
REVISION SUMMARY
When an application is not responding, its window is desaturated to communicate \
this. Also "(Not Responding)" is added to the title bar.
TEST PLAN
(Originally created as https://git.reviewboard.kde.org/r/127162/ - in contrast to \
the older review, this here only changes the looks of the window, it leaves the kill \
prompt alone)
I'm absolutely certain there is a bug/wish on bko about this. X only right now, I \
don't think we have ping/kill infrastructure on Wayland yet?
VDG: When an application freezes and I click the close button, after 2.5s it will \
desaturate the window, after another 2.5s it will show the "do you want to kill $app" \
prompt. If I then choose "Wait longer", the prompt closes and the window remains \
desaturated until the app responds again. I can click the close button again, and get \
the "do you want to kill $app" prompt again (after 2.5s, for subsequent calls, \
though). It doesn't happen if you interact with the window in any other way, only the \
close button "pings" the client.
- Running the timer twice is probably more of a hack, when the client is already \
marked unresponsive, which halves the timeout when the kill dialog is triggered on \
subsequent invocations
- Not sure about the "(Not Responding)" part in title bar (also do we have \
Message.sh for deco?), I chose not to manipulate the client's caption but do it only \
in the decoration. Maybe we can improve the look, even?
F3429932: Screenshot_20170329_163316.png <https://phabricator.kde.org/F3429932>
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D5245
AFFECTED FILES
abstract_client.cpp
abstract_client.h
client.cpp
decorations/decoratedclient.cpp
effects.cpp
effects.h
effects/CMakeLists.txt
effects/frozenapp/CMakeLists.txt
effects/frozenapp/package/CMakeLists.txt
effects/frozenapp/package/contents/code/main.js
effects/frozenapp/package/metadata.desktop
libkwineffects/kwineffects.h
To: broulik, #plasma, #kwin, #vdg
Cc: plasma-devel, kwin, progwolff, lesliezhai, ali-mohamed, hardening, \
jensreuterberg, abetts, sebas, apol
[Attachment #3 (text/html)]
<table><tr><td style="">broulik created this revision.<br />Restricted Application \
added a project: KWin.<br />Restricted Application added subscribers: kwin, \
plasma-devel. </td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px \
8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; \
background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); \
display: inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D5245" rel="noreferrer">View \
Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>When an \
application is not responding, its window is desaturated to communicate this. Also \
"(Not Responding)" is added to the title bar.</p></div></div><br \
/><div><strong>TEST PLAN</strong><div><p>(Originally created as <a \
href="https://git.reviewboard.kde.org/r/127162/" class="remarkup-link" \
target="_blank" rel="noreferrer">https://git.reviewboard.kde.org/r/127162/</a> - in \
contrast to the older review, this here only changes the looks of the window, it \
leaves the kill prompt alone)</p>
<p>I'm absolutely certain there is a bug/wish on bko about this. X only right \
now, I don't think we have ping/kill infrastructure on Wayland yet?</p>
<p>VDG: When an application freezes and I click the close button, after 2.5s it will \
desaturate the window, after another 2.5s it will show the "do you want to kill \
$app" prompt. If I then choose "Wait longer", the prompt closes and \
the window remains desaturated until the app responds again. I can click the close \
button again, and get the "do you want to kill $app" prompt again (after \
2.5s, for subsequent calls, though). It doesn't happen if you interact with the \
window in any other way, only the close button "pings" the client.</p>
<ul class="remarkup-list">
<li class="remarkup-list-item">Running the timer twice is probably more of a hack, \
when the client is already marked unresponsive, which halves the timeout when the \
kill dialog is triggered on subsequent invocations</li> <li \
class="remarkup-list-item">Not sure about the "(Not Responding)" part in \
title bar (also do we have Message.sh for deco?), I chose not to manipulate the \
client's caption but do it only in the decoration. Maybe we can improve the \
look, even?</li> </ul>
<p><a href="https://phabricator.kde.org/F3429932" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;" rel="noreferrer">F3429932: \
Screenshot_20170329_163316.png</a></p></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R108 KWin</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D5245" \
rel="noreferrer">https://phabricator.kde.org/D5245</a></div></div><br \
/><div><strong>AFFECTED FILES</strong><div><div>abstract_client.cpp<br /> \
abstract_client.h<br /> client.cpp<br />
decorations/decoratedclient.cpp<br />
effects.cpp<br />
effects.h<br />
effects/CMakeLists.txt<br />
effects/frozenapp/CMakeLists.txt<br />
effects/frozenapp/package/CMakeLists.txt<br />
effects/frozenapp/package/contents/code/main.js<br />
effects/frozenapp/package/metadata.desktop<br />
libkwineffects/kwineffects.h</div></div></div><br /><div><strong>To: \
</strong>broulik, Plasma, KWin, VDG<br /><strong>Cc: </strong>plasma-devel, kwin, \
progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol<br \
/></div>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic