[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    D5225: [slidingpopups] Only remove WindowClosedGrabRole if the effect owns the grab
From:       Martin_Gräßlin <noreply () phabricator ! kde ! org>
Date:       2017-03-28 15:52:45
Message-ID: differential-rev-PHID-DREV-56dhimji4f4qhqqcs4by-req () phabricator ! kde ! org
[Download RAW message or body]

graesslin created this revision.
Restricted Application added a project: KWin.
Restricted Application added subscribers: kwin, plasma-devel.

REVISION SUMMARY
  The effect unset the WindowClosedGrabRole unconditionally if it does not
  manage the window. This results in any grab set by other effects to break.
  
  BUG: 376609
  FIXED-IN: 5.9.5

REPOSITORY
  R108 KWin

BRANCH
  slidingpopups-no-unconditional-grab-unset-5.9

REVISION DETAIL
  https://phabricator.kde.org/D5225

AFFECTED FILES
  effects/slidingpopups/slidingpopups.cpp

To: graesslin, #kwin, #plasma
Cc: plasma-devel, kwin, progwolff, lesliezhai, ali-mohamed, hardening, \
jensreuterberg, abetts, sebas, apol


[Attachment #3 (text/html)]

<table><tr><td style="">graesslin created this revision.<br />Restricted Application \
added a project: KWin.<br />Restricted Application added subscribers: kwin, \
plasma-devel. </td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px \
8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; \
background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); \
display: inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D5225" rel="noreferrer">View \
Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>The \
effect unset the WindowClosedGrabRole unconditionally if it does not<br /> manage the \
window. This results in any grab set by other effects to break.</p>

<p>BUG: 376609<br />
FIXED-IN: 5.9.5</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R108 \
KWin</div></div></div><br \
/><div><strong>BRANCH</strong><div><div>slidingpopups-no-unconditional-grab-unset-5.9</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D5225" \
rel="noreferrer">https://phabricator.kde.org/D5225</a></div></div><br \
/><div><strong>AFFECTED \
FILES</strong><div><div>effects/slidingpopups/slidingpopups.cpp</div></div></div><br \
/><div><strong>To: </strong>graesslin, KWin, Plasma<br /><strong>Cc: \
</strong>plasma-devel, kwin, progwolff, lesliezhai, ali-mohamed, hardening, \
jensreuterberg, abetts, sebas, apol<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]