[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    D3504: Implment DRM EGL scaling
From:       Roman Gilg <noreply () phabricator ! kde ! org>
Date:       2017-03-25 19:26:11
Message-ID: 20170325192611.68054.94378.BE2B629F () phabricator ! kde ! org
[Download RAW message or body]

subdiff added inline comments.

INLINE COMMENTS

> subdiff wrote in egl_gbm_backend.cpp:159
> You could add to `struct Output` a value for that, which you then use in \
> makeContextCurrent.

Better: Add an additional variable of the "real" unscaled output size in DrmOutput \
with appropriate getter to also solve the rounding issue from the other Diff.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D3504

To: davidedmundson, #plasma, graesslin
Cc: subdiff, graesslin, plasma-devel, kwin, progwolff, lesliezhai, ali-mohamed, \
hardening, jensreuterberg, abetts, sebas, apol


[Attachment #3 (text/html)]

<table><tr><td style="">subdiff added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D3504" rel="noreferrer">View \
Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div \
style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: \
3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; \
border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; \
background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; \
text-decoration: none;" href="https://phabricator.kde.org/D3504#inline-21269" \
rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: \
bold;">subdiff</span> wrote in <span style="color: #4b4d51; font-weight: \
bold;">egl_gbm_backend.cpp:159</span></div> <div style="margin: 8px 0; padding: 0 \
12px; color: #74777D;"><p style="padding: 0; margin: 8px;">You could add to <tt \
style="background: #ebebeb; font-size: 13px;">struct Output</tt> a value for that, \
which you then use in makeContextCurrent.</p></div></div> <div style="margin: 8px 0; \
padding: 0 12px;"><p style="padding: 0; margin: 8px;">Better: Add an additional \
variable of the &quot;real&quot; unscaled output size in DrmOutput with appropriate \
getter to also solve the rounding issue from the other \
Diff.</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R108 KWin</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D3504" \
rel="noreferrer">https://phabricator.kde.org/D3504</a></div></div><br \
/><div><strong>To: </strong>davidedmundson, Plasma, graesslin<br /><strong>Cc: \
</strong>subdiff, graesslin, plasma-devel, kwin, progwolff, lesliezhai, ali-mohamed, \
hardening, jensreuterberg, abetts, sebas, apol<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]