[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request 130025: Fix crash on dragging titlebar buttons in System Settings
From: Martin_Gräßlin <mgraesslin () kde ! org>
Date: 2017-03-20 16:11:37
Message-ID: 20170320161137.6541.50529 () mimi ! kde ! org
[Download RAW message or body]
--===============3315736192813952281==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130025/#review102914
-----------------------------------------------------------
Ship it!
Ship It!
- Martin Gräßlin
On March 17, 2017, 2:24 p.m., Vladyslav Tronko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/130025/
> -----------------------------------------------------------
>
> (Updated March 17, 2017, 2:24 p.m.)
>
>
> Review request for kwin and Martin Gräßlin.
>
>
> Repository: kwin
>
>
> Description
> -------
>
> Currently, if user tries to move one of buttons to the left, ending up
> dragging one button onto another, crash occurs.
>
> In addition, this patch replaces verbose replacement(remove/insert) with
> more elegant QVector<T>::move(int, int)
>
>
> Diffs
> -----
>
> kcmkwin/kwindecoration/declarative-plugin/buttonsmodel.cpp \
> 26d779015673780458ca5a9d3514341ccb83fea0
> Diff: https://git.reviewboard.kde.org/r/130025/diff/
>
>
> Testing
> -------
>
> Works as expected on ArchLinux x86_64
>
>
> Thanks,
>
> Vladyslav Tronko
>
>
--===============3315736192813952281==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/130025/">https://git.reviewboard.kde.org/r/130025/</a>
</td>
</tr>
</table>
<br />
<p>
Ship it!
</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre> <br />
<p>- Martin Gräßlin</p>
<br />
<p>On March 17th, 2017, 2:24 p.m. CET, Vladyslav Tronko wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for kwin and Martin Gräßlin.</div>
<div>By Vladyslav Tronko.</div>
<p style="color: grey;"><i>Updated March 17, 2017, 2:24 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kwin
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Currently, if user tries to move one of buttons to the left, ending up \
dragging one button onto another, crash occurs.
In addition, this patch replaces verbose replacement(remove/insert) with
more elegant QVector<T>::move(int, int)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Works as expected on ArchLinux x86_64</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kcmkwin/kwindecoration/declarative-plugin/buttonsmodel.cpp <span style="color: \
grey">(26d779015673780458ca5a9d3514341ccb83fea0)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/130025/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============3315736192813952281==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic