[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request 128824: Add KWindowSystem::closeWindow(WId) and its unit test
From: Thomas_Lübking <thomas.luebking () gmail ! com>
Date: 2016-09-03 21:16:11
Message-ID: 20160903211611.21343.49781 () mimi ! kde ! org
[Download RAW message or body]
--===============3533561486946548416==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128824/#review98850
-----------------------------------------------------------
See https://git.reviewboard.kde.org/r/127992/
- Thomas Lübking
On Sept. 3, 2016, 9:12 nachm., Paulo Lieuthier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128824/
> -----------------------------------------------------------
>
> (Updated Sept. 3, 2016, 9:12 nachm.)
>
>
> Review request for kwin and Martin Gräßlin.
>
>
> Repository: kwindowsystem
>
>
> Description
> -------
>
> This missing function will enable LXQt's taskbar to not depend directly on \
> NETRootInfo or KWayland. It's weird you haven't added it before, as Plasma's old \
> and new taskbars call the base libraries directly as far as I can see.
>
> Diffs
> -----
>
> autotests/kwindowsystemx11test.cpp 363c805
> src/kwindowsystem.h a282ecd
> src/kwindowsystem.cpp fda1682
> src/kwindowsystem_dummy_p.h 736a6f2
> src/kwindowsystem_p.h 5f30042
> src/platforms/osx/kwindowsystem.cpp 1758829
> src/platforms/wayland/kwindowsystem.cpp a5dfa93
> src/platforms/wayland/kwindowsystem_p_wayland.h 14aa73e
> src/platforms/xcb/kwindowsystem.cpp 091c71a
> src/platforms/xcb/kwindowsystem_p_x11.h 72df642
>
> Diff: https://git.reviewboard.kde.org/r/128824/diff/
>
>
> Testing
> -------
>
> I installed on my system and tested it through LXQt's taskbar.
>
>
> Thanks,
>
> Paulo Lieuthier
>
>
--===============3533561486946548416==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/128824/">https://git.reviewboard.kde.org/r/128824/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">See \
https://git.reviewboard.kde.org/r/127992/</p></pre> <br />
<p>- Thomas Lübking</p>
<br />
<p>On September 3rd, 2016, 9:12 nachm. UTC, Paulo Lieuthier wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for kwin and Martin Gräßlin.</div>
<div>By Paulo Lieuthier.</div>
<p style="color: grey;"><i>Updated Sept. 3, 2016, 9:12 nachm.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kwindowsystem
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This missing function will enable LXQt's taskbar to \
not depend directly on NETRootInfo or KWayland. It's weird you haven't added it \
before, as Plasma's old and new taskbars call the base libraries directly as far as I \
can see.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">I installed on my system and tested it through LXQt's \
taskbar.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>autotests/kwindowsystemx11test.cpp <span style="color: \
grey">(363c805)</span></li>
<li>src/kwindowsystem.h <span style="color: grey">(a282ecd)</span></li>
<li>src/kwindowsystem.cpp <span style="color: grey">(fda1682)</span></li>
<li>src/kwindowsystem_dummy_p.h <span style="color: grey">(736a6f2)</span></li>
<li>src/kwindowsystem_p.h <span style="color: grey">(5f30042)</span></li>
<li>src/platforms/osx/kwindowsystem.cpp <span style="color: \
grey">(1758829)</span></li>
<li>src/platforms/wayland/kwindowsystem.cpp <span style="color: \
grey">(a5dfa93)</span></li>
<li>src/platforms/wayland/kwindowsystem_p_wayland.h <span style="color: \
grey">(14aa73e)</span></li>
<li>src/platforms/xcb/kwindowsystem.cpp <span style="color: \
grey">(091c71a)</span></li>
<li>src/platforms/xcb/kwindowsystem_p_x11.h <span style="color: \
grey">(72df642)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/128824/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============3533561486946548416==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic