[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request 128647: [DesktopView] Stop raising desktop over dialog windows
From: Anthony Fieroni <bvbfan () abv ! bg>
Date: 2016-08-13 5:12:18
Message-ID: 20160813051218.25340.78314 () mimi ! kde ! org
[Download RAW message or body]
--===============0050803135221694334==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
> On Авг. 12, 2016, 2:31 след обяд, Martin Gräßlin wrote:
> > Could someone please test, whether this works?
> >
> > diff --git a/shell/desktopview.cpp b/shell/desktopview.cpp
> > index 14a25af..38c6621 100644
> > --- a/shell/desktopview.cpp
> > +++ b/shell/desktopview.cpp
> > @@ -226,6 +226,7 @@ bool DesktopView::event(QEvent *e)
> > switch (pe->surfaceEventType()) {
> > case QPlatformSurfaceEvent::SurfaceCreated:
> > setupWaylandIntegration();
> > + ensureWindowType();
> > break;
> > case QPlatformSurfaceEvent::SurfaceAboutToBeDestroyed:
> > delete m_shellSurface;
>
> Anthony Fieroni wrote:
> I can't get plasmashell to work in wayland on my skylake laptop, it crashes every \
> time.
> Martin Gräßlin wrote:
> I meant to test that on X11, not on Wayland. On Wayland I can test myself :-)
>
> Anthony Fieroni wrote:
> How this expect to work? Multiple calls in setFlags triggers the bug, if we remove \
> esureWindowType at focusIn then it *should* work.
> Thomas Lübking wrote:
> The implication is probably to remove it *everywhere* else.
>
> Martin Gräßlin wrote:
> yep, the idea is whether the types is set correctly after surface created. If it is \
> we can remove all other calls.
On screen changes should to stay and in setWindowType too. We can remove only on \
focusIn.
- Anthony
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128647/#review98334
-----------------------------------------------------------
On Авг. 10, 2016, 9:28 след обяд, Anthony Fieroni wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128647/
> -----------------------------------------------------------
>
> (Updated Авг. 10, 2016, 9:28 след обяд)
>
>
> Review request for kwin, Plasma, David Edmundson, David Rosca, and Marco Martin.
>
>
> Bugs: 350826 and 365014
> https://bugs.kde.org/show_bug.cgi?id=350826
> https://bugs.kde.org/show_bug.cgi?id=365014
>
>
> Repository: plasma-workspace
>
>
> Description
> -------
>
> ^^
>
>
> Diffs
> -----
>
> shell/desktopview.cpp 83866dc
>
> Diff: https://git.reviewboard.kde.org/r/128647/diff/
>
>
> Testing
> -------
>
> 1. open 1 or more non maximized windows
> 2. make left clicks periodically between window and the desktop
> 3. desktop is raised over opened windows *sometimes*
>
>
> Thanks,
>
> Anthony Fieroni
>
>
--===============0050803135221694334==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/128647/">https://git.reviewboard.kde.org/r/128647/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On Август 12th, 2016, 2:31 след обяд \
EEST, <b>Martin Gräßlin</b> wrote:</p> <blockquote style="margin-left: 1em; \
border-left: 2px solid #d0d0d0; padding-left: 10px;"> <pre style="white-space: \
pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: \
-o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">Could someone please \
test, whether this works?</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;"><div class="codehilite" \
style="background: #f8f8f8"><pre style="line-height: 125%"><span style="color: \
#000080; font-weight: bold">diff --git a/shell/desktopview.cpp \
b/shell/desktopview.cpp</span> <span style="color: #000080; font-weight: bold">index \
14a25af..38c6621 100644</span> <span style="color: #A00000">--- \
a/shell/desktopview.cpp</span> <span style="color: #00A000">+++ \
b/shell/desktopview.cpp</span> <span style="color: #800080; font-weight: bold">@@ \
-226,6 +226,7 @@ bool DesktopView::event(QEvent *e)</span> switch \
(pe->surfaceEventType()) { case QPlatformSurfaceEvent::SurfaceCreated:
setupWaylandIntegration();
<span style="color: #00A000">+ ensureWindowType();</span>
break;
case QPlatformSurfaceEvent::SurfaceAboutToBeDestroyed:
delete m_shellSurface;
</pre></div>
</p></pre>
</blockquote>
<p>On Август 12th, 2016, 3:40 след обяд EEST, <b>Anthony Fieroni</b> \
wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; \
padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">I can't get plasmashell to work in wayland on my skylake laptop, it crashes \
every time.</p></pre> </blockquote>
<p>On Август 12th, 2016, 5:19 след обяд EEST, <b>Martin Gräßlin</b> \
wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; \
padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">I meant to test that on X11, not on Wayland. On Wayland I can test myself \
:-)</p></pre> </blockquote>
<p>On Август 12th, 2016, 5:52 след обяд EEST, <b>Anthony Fieroni</b> \
wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; \
padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">How this expect to work? Multiple calls in setFlags triggers the bug, if we \
remove esureWindowType at focusIn then it <em style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;">should</em> \
work.</p></pre> </blockquote>
<p>On Август 12th, 2016, 5:55 след обяд EEST, <b>Thomas Lübking</b> \
wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; \
padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">The implication is probably to remove it <em style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;">everywhere</em> else.</p></pre> </blockquote>
<p>On Август 12th, 2016, 6:02 след обяд EEST, <b>Martin Gräßlin</b> \
wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; \
padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">yep, the idea is whether the types is set correctly after surface created. \
If it is we can remove all other calls.</p></pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">On \
screen changes should to stay and in setWindowType too. We can remove only on \
focusIn.</p></pre> <br />
<p>- Anthony</p>
<br />
<p>On Август 10th, 2016, 9:28 след обяд EEST, Anthony Fieroni \
wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for kwin, Plasma, David Edmundson, David Rosca, and Marco \
Martin.</div> <div>By Anthony Fieroni.</div>
<p style="color: grey;"><i>Updated Авг. 10, 2016, 9:28 след обяд</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=350826">350826</a>,
<a href="https://bugs.kde.org/show_bug.cgi?id=365014">365014</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">^^</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><ol style="padding: 0;text-rendering: inherit;margin: 0 0 0 \
2em;line-height: inherit;white-space: normal;"> <li style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;">open 1 or more non \
maximized windows</li> <li style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: normal;">make left clicks periodically between \
window and the desktop</li> <li style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: normal;">desktop is raised over opened windows \
<em style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: normal;">sometimes</em></li> </ol></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>shell/desktopview.cpp <span style="color: grey">(83866dc)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/128647/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============0050803135221694334==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic