From kwin Fri Aug 12 14:55:32 2016 From: =?utf-8?q?Thomas_L=C3=BCbking?= Date: Fri, 12 Aug 2016 14:55:32 +0000 To: kwin Subject: Re: Review Request 128647: [DesktopView] Stop raising desktop over dialog windows Message-Id: <20160812145532.25340.62742 () mimi ! kde ! org> X-MARC-Message: https://marc.info/?l=kwin&m=147101376314905 --===============1347617464507314387== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit > On Aug. 12, 2016, 11:31 vorm., Martin Gräßlin wrote: > > Could someone please test, whether this works? > > > > diff --git a/shell/desktopview.cpp b/shell/desktopview.cpp > > index 14a25af..38c6621 100644 > > --- a/shell/desktopview.cpp > > +++ b/shell/desktopview.cpp > > @@ -226,6 +226,7 @@ bool DesktopView::event(QEvent *e) > > switch (pe->surfaceEventType()) { > > case QPlatformSurfaceEvent::SurfaceCreated: > > setupWaylandIntegration(); > > + ensureWindowType(); > > break; > > case QPlatformSurfaceEvent::SurfaceAboutToBeDestroyed: > > delete m_shellSurface; > > Anthony Fieroni wrote: > I can't get plasmashell to work in wayland on my skylake laptop, it crashes every time. > > Martin Gräßlin wrote: > I meant to test that on X11, not on Wayland. On Wayland I can test myself :-) > > Anthony Fieroni wrote: > How this expect to work? Multiple calls in setFlags triggers the bug, if we remove esureWindowType at focusIn then it *should* work. The implication is probably to remove it *everywhere* else. - Thomas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128647/#review98334 ----------------------------------------------------------- On Aug. 10, 2016, 6:28 nachm., Anthony Fieroni wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128647/ > ----------------------------------------------------------- > > (Updated Aug. 10, 2016, 6:28 nachm.) > > > Review request for kwin, Plasma, David Edmundson, David Rosca, and Marco Martin. > > > Bugs: 350826 and 365014 > https://bugs.kde.org/show_bug.cgi?id=350826 > https://bugs.kde.org/show_bug.cgi?id=365014 > > > Repository: plasma-workspace > > > Description > ------- > > ^^ > > > Diffs > ----- > > shell/desktopview.cpp 83866dc > > Diff: https://git.reviewboard.kde.org/r/128647/diff/ > > > Testing > ------- > > 1. open 1 or more non maximized windows > 2. make left clicks periodically between window and the desktop > 3. desktop is raised over opened windows *sometimes* > > > Thanks, > > Anthony Fieroni > > --===============1347617464507314387== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 8bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128647/

On August 12th, 2016, 11:31 vorm. UTC, Martin Gräßlin wrote:

Could someone please test, whether this works?
diff --git a/shell/desktopview.cpp b/shell/desktopview.cpp
index 14a25af..38c6621 100644
--- a/shell/desktopview.cpp
+++ b/shell/desktopview.cpp
@@ -226,6 +226,7 @@ bool DesktopView::event(QEvent *e)
             switch (pe->surfaceEventType()) {
             case QPlatformSurfaceEvent::SurfaceCreated:
                 setupWaylandIntegration();
+                ensureWindowType();
                 break;
             case QPlatformSurfaceEvent::SurfaceAboutToBeDestroyed:
                 delete m_shellSurface;

On August 12th, 2016, 12:40 nachm. UTC, Anthony Fieroni wrote:

I can't get plasmashell to work in wayland on my skylake laptop, it crashes every time.

On August 12th, 2016, 2:19 nachm. UTC, Martin Gräßlin wrote:

I meant to test that on X11, not on Wayland. On Wayland I can test myself :-)

On August 12th, 2016, 2:52 nachm. UTC, Anthony Fieroni wrote:

How this expect to work? Multiple calls in setFlags triggers the bug, if we remove esureWindowType at focusIn then it should work.

The implication is probably to remove it everywhere else.

- Thomas

On August 10th, 2016, 6:28 nachm. UTC, Anthony Fieroni wrote:

Review request for kwin, Plasma, David Edmundson, David Rosca, and Marco Martin.

By Anthony Fieroni.

Updated Aug. 10, 2016, 6:28 nachm.

Bugs: 350826, 365014

Repository: plasma-workspace

Description

^^

Testing


open 1 or more non maximized windows
make left clicks periodically between window and the desktop
desktop is raised over opened windows sometimes

Diffs

shell/desktopview.cpp (83866dc)

--===============1347617464507314387==--