[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request 128636: [libkwin] Stop raising the desktop
From: Thomas_Lübking <thomas.luebking () gmail ! com>
Date: 2016-08-10 13:30:19
Message-ID: 20160810133019.9365.99672 () mimi ! kde ! org
[Download RAW message or body]
--===============2792479945744725742==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
> On Aug. 10, 2016, 9:45 vorm., Martin Gräßlin wrote:
> > KWin is the wrong place to fix this bug. It needs to be fixed in plasmashell as \
> > Thomas already said.
>
> Anthony Fieroni wrote:
> Martin do you want this patch as you TODO does?
> // TODO: does it make sense to cache the returned window type for \
> SUPPORTED_MANAGED_WINDOW_TYPES_MASK?
> Martin Gräßlin wrote:
> looking at the code: this method is fast - also the invoked one in NETWinInfo I \
> know to be fast. Given that the answer to the question I asked myself in that TODO \
> is: "no, it doesn't make sense to cache the returned window type". And the question \
> was only concerning performance as it got added in an optimization change.
> Overall I don't like the patch due to the usage of mutuable. That just means that \
> something is wrong there.
> Anthony Fieroni wrote:
> It's standart to me, i can correct it if you want or to discard it.
> It's standard to me
Should not be.
Setting a member mutable allows to alter it even if accessing the class "const", eg. \
from const member functions. It does _not_ fit regular data members.
- Thomas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128636/#review98274
-----------------------------------------------------------
On Aug. 10, 2016, 3:41 vorm., Anthony Fieroni wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128636/
> -----------------------------------------------------------
>
> (Updated Aug. 10, 2016, 3:41 vorm.)
>
>
> Review request for kwin, David Edmundson and Martin Gräßlin.
>
>
> Bugs: 350826 and 365014
> https://bugs.kde.org/show_bug.cgi?id=350826
> https://bugs.kde.org/show_bug.cgi?id=365014
>
>
> Repository: kwin
>
>
> Description
> -------
>
> Desktop must not be raised, this cannot be a proper patch, but it's needed more \
> investigate to track this down.
>
> Diffs
> -----
>
> client.h 08e25ab
> client.cpp 2e69666
> unmanaged.h 31aea04
> unmanaged.cpp 1a76175
>
> Diff: https://git.reviewboard.kde.org/r/128636/diff/
>
>
> Testing
> -------
>
> 1. open 1 or more non maximized windows
> 2. make left clicks periodically between window and the desktop
> 3. desktop is raised over opened windows *sometimes*
>
>
> Thanks,
>
> Anthony Fieroni
>
>
--===============2792479945744725742==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/128636/">https://git.reviewboard.kde.org/r/128636/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On August 10th, 2016, 9:45 vorm. UTC, <b>Martin \
Gräßlin</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">KWin is the wrong place to fix this bug. It needs to \
be fixed in plasmashell as Thomas already said.</p></pre> </blockquote>
<p>On August 10th, 2016, 11:23 vorm. UTC, <b>Anthony Fieroni</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Martin do you want this patch as you TODO does? // TODO: does it make sense \
to cache the returned window type for SUPPORTED_MANAGED_WINDOW_TYPES_MASK?</p></pre> \
</blockquote>
<p>On August 10th, 2016, 12:33 nachm. UTC, <b>Martin Gräßlin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">looking at the code: this method is fast - also the invoked one in \
NETWinInfo I know to be fast. Given that the answer to the question I asked myself in \
that TODO is: "no, it doesn't make sense to cache the returned window type". And the \
question was only concerning performance as it got added in an optimization \
change.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Overall I don't like the patch due to the usage of \
mutuable. That just means that something is wrong there.</p></pre> </blockquote>
<p>On August 10th, 2016, 1:17 nachm. UTC, <b>Anthony Fieroni</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">It's \
standart to me, i can correct it if you want or to discard it.</p></pre> \
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><blockquote \
style="text-rendering: inherit;padding: 0 0 0 1em;border-left: 1px solid \
#bbb;white-space: normal;margin: 0 0 0 0.5em;line-height: inherit;"> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">It's standard to me</p> </blockquote>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Should not be. Setting a member mutable allows to \
alter it even if accessing the class "const", eg. from const member functions. It \
does <em style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: normal;">not</em> fit regular data members.</p></pre> <br />
<p>- Thomas</p>
<br />
<p>On August 10th, 2016, 3:41 vorm. UTC, Anthony Fieroni wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for kwin, David Edmundson and Martin Gräßlin.</div>
<div>By Anthony Fieroni.</div>
<p style="color: grey;"><i>Updated Aug. 10, 2016, 3:41 vorm.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=350826">350826</a>,
<a href="https://bugs.kde.org/show_bug.cgi?id=365014">365014</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kwin
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Desktop must not be raised, this cannot be a proper \
patch, but it's needed more investigate to track this down.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><ol style="padding: 0;text-rendering: inherit;margin: 0 0 0 \
2em;line-height: inherit;white-space: normal;"> <li style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;">open 1 or more non \
maximized windows</li> <li style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: normal;">make left clicks periodically between \
window and the desktop</li> <li style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: normal;">desktop is raised over opened windows \
<em style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: normal;">sometimes</em></li> </ol></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>client.h <span style="color: grey">(08e25ab)</span></li>
<li>client.cpp <span style="color: grey">(2e69666)</span></li>
<li>unmanaged.h <span style="color: grey">(31aea04)</span></li>
<li>unmanaged.cpp <span style="color: grey">(1a76175)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/128636/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============2792479945744725742==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic