[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request 128636: [libkwin] Stop raising the desktop
From: Christoph Feck <cfeck () kde ! org>
Date: 2016-08-09 19:06:15
Message-ID: 20160809190615.9365.67891 () mimi ! kde ! org
[Download RAW message or body]
--===============6531582379464257626==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
> On Aug. 9, 2016, 5:26 p.m., Thomas Lübking wrote:
> > If you're (likely) facing bug #350826 this isn't gonna fix it but just breaks the \
> > "show desktop" feature.
>
> Anthony Fieroni wrote:
> No. When perform click over the desktop it raises over visible windows. I can make \
> video for that if you can't catch it.
> Thomas Lübking wrote:
> Yes and that happens because the window is temporarily no desktop. We know this \
> bug. The solution is to stop plasmashell from juggling its type (the way to btw. \
> confirm the bug is to spy the prop, see bug)
> Alternatively, kwin could fully track the type (you'll still get brief layer \
> changes, but they might be covered by the compositor) because that's the awesome \
> way for totally awesome qtquic
> Anthony Fieroni wrote:
> Oh your last comment, i don't see it. So what can be done?
>
> Anthony Fieroni wrote:
> Ah, i never see it before 5.7 branch, why?
>
> Anthony Fieroni wrote:
> Possible solution, to fetch desktop only one
>
> m_isDesktop = windowType() == NET::Desktop; // probably in ctor ?
>
> inline bool Toplevel::isDesktop() const
> {
> return m_isDesktop;
> }
>
> What you think?
I added bug 365014, because this issue is newer/different than what is reported in \
the old bug.
- Christoph
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128636/#review98231
-----------------------------------------------------------
On Aug. 9, 2016, 7:05 p.m., Anthony Fieroni wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128636/
> -----------------------------------------------------------
>
> (Updated Aug. 9, 2016, 7:05 p.m.)
>
>
> Review request for kwin and Martin Gräßlin.
>
>
> Bugs: 350826 and 365014
> https://bugs.kde.org/show_bug.cgi?id=350826
> https://bugs.kde.org/show_bug.cgi?id=365014
>
>
> Repository: kwin
>
>
> Description
> -------
>
> Desktop must not be raised, this cannot be a proper patch, but it's needed more \
> investigate to track this down.
>
> Diffs
> -----
>
> layers.cpp 2edfda0
>
> Diff: https://git.reviewboard.kde.org/r/128636/diff/
>
>
> Testing
> -------
>
> 1. open 1 or more non maximized windows
> 2. make left clicks periodically between window and the desktop
> 3. desktop is raised over opened windows *sometimes*
>
>
> Thanks,
>
> Anthony Fieroni
>
>
--===============6531582379464257626==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/128636/">https://git.reviewboard.kde.org/r/128636/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On August 9th, 2016, 5:26 p.m. UTC, <b>Thomas \
Lübking</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">If you're (likely) facing bug #350826 this isn't gonna \
fix it but just breaks the "show desktop" feature.</p></pre> </blockquote>
<p>On August 9th, 2016, 6:07 p.m. UTC, <b>Anthony Fieroni</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">No. \
When perform click over the desktop it raises over visible windows. I can make video \
for that if you can't catch it.</p></pre> </blockquote>
<p>On August 9th, 2016, 6:22 p.m. UTC, <b>Thomas Lübking</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Yes \
and that happens because the window is temporarily no desktop. We know this bug. The \
solution is to stop plasmashell from juggling its type (the way to btw. confirm the \
bug is to spy the prop, see bug)</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">Alternatively, kwin \
could fully track the type (you'll still get brief layer changes, but they might be \
covered by the compositor) because that's the awesome way for totally awesome \
qtquic</p></pre> </blockquote>
<p>On August 9th, 2016, 6:26 p.m. UTC, <b>Anthony Fieroni</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Oh \
your last comment, i don't see it. So what can be done?</p></pre> </blockquote>
<p>On August 9th, 2016, 6:29 p.m. UTC, <b>Anthony Fieroni</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Ah, i \
never see it before 5.7 branch, why?</p></pre> </blockquote>
<p>On August 9th, 2016, 6:41 p.m. UTC, <b>Anthony Fieroni</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Possible solution, to fetch desktop only one</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">m_isDesktop = windowType() == NET::Desktop; // probably in ctor ?</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">inline bool Toplevel::isDesktop() const {
return m_isDesktop;
}</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">What you think?</p></pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I \
added bug 365014, because this issue is newer/different than what is reported in the \
old bug.</p></pre> <br />
<p>- Christoph</p>
<br />
<p>On August 9th, 2016, 7:05 p.m. UTC, Anthony Fieroni wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for kwin and Martin Gräßlin.</div>
<div>By Anthony Fieroni.</div>
<p style="color: grey;"><i>Updated Aug. 9, 2016, 7:05 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=350826">350826</a>,
<a href="https://bugs.kde.org/show_bug.cgi?id=365014">365014</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kwin
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Desktop must not be raised, this cannot be a proper \
patch, but it's needed more investigate to track this down.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><ol style="padding: 0;text-rendering: inherit;margin: 0 0 0 \
2em;line-height: inherit;white-space: normal;"> <li style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;">open 1 or more non \
maximized windows</li> <li style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: normal;">make left clicks periodically between \
window and the desktop</li> <li style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: normal;">desktop is raised over opened windows \
<em style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: normal;">sometimes</em></li> </ol></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>layers.cpp <span style="color: grey">(2edfda0)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/128636/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============6531582379464257626==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic