[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    [Differential] [Commented On] D1982: Validate activities in setOnActivities
From:       "davidedmundson (David Edmundson)" <noreply () phabricator ! kde ! org>
Date:       2016-06-24 7:42:28
Message-ID: 20160624074224.102492.529.33E25EBF () phabricator ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


davidedmundson added a comment.


  In https://phabricator.kde.org/D1982#36569, @luebking wrote:
  
  > in the noop case.
  >  otherwise there's an unnecessary detach and on top of this there's a
  >  useless secondary lookup for the removeOne() call.
  >
  > it's not getting much worse unless you add some bitcoin mining in every
  >  loop :-P
  
  
  Swing and a miss.
  
  There's no extra detatch because we have a reference to the original full \
QStringList in whatever stack called setOnActivities.  So the copy taken by the \
foreach will always be the same list as the one on the stack in whoever called us.  \
In both cases, one detach  
  (the extra lookup argument is valid)

REPOSITORY
  rKWIN KWin

REVISION DETAIL
  https://phabricator.kde.org/D1982

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma, graesslin
Cc: luebking, graesslin, kwin, hardening, jensreuterberg, sebas


[Attachment #5 (text/html)]

<table><tr><td style="">davidedmundson added a comment.</td><a \
style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; \
color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; \
background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; \
border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D1982" \
rel="noreferrer">View Revision</a></tr></table><br /><div><div><blockquote \
style="border-left: 3px solid #8C98B8;  color: #6B748C;
          font-style: italic;
          margin: 4px 0 12px 0;
          padding: 8px 12px;
          background-color: #F8F9FC;">
<div style="font-style: normal;
          padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D1982#36569" \
style="background-color: #e7e7e7;  border-color: #e7e7e7;
          border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: none;" rel="noreferrer">D1982#36569</a>, <a \
href="https://phabricator.kde.org/p/luebking/" style="  border-color: #f1f7ff;
              color: #19558d;
              background-color: #f1f7ff;
                border: 1px solid transparent;
                border-radius: 3px;
                font-weight: bold;
                padding: 0 4px;" rel="noreferrer">@luebking</a> wrote:</div>
<div style="margin: 0;
          padding: 0;
          border: 0;
          color: rgb(107, 116, 140);"><p>in the noop case.<br />
 otherwise there&#039;s an unnecessary detach and on top of this there&#039;s a<br />
 useless secondary lookup for the removeOne() call.</p>

<p>it&#039;s not getting much worse unless you add some bitcoin mining in every<br />
 loop :-P</p></div>
</blockquote>

<p>Swing and a miss.</p>

<p>There&#039;s no extra detatch because we have a reference to the original full \
QStringList in whatever stack called setOnActivities.<br /> So the copy taken by the \
foreach will always be the same list as the one on the stack in whoever called us.<br \
/> In both cases, one detach</p>

<p>(the extra lookup argument is valid)</p></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>rKWIN KWin</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D1982" \
rel="noreferrer">https://phabricator.kde.org/D1982</a></div></div><br \
/><div><strong>EMAIL PREFERENCES</strong><div><a \
href="https://phabricator.kde.org/settings/panel/emailpreferences/" \
rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br \
/><div><strong>To: </strong>davidedmundson, Plasma, graesslin<br /><strong>Cc: \
</strong>luebking, graesslin, kwin, hardening, jensreuterberg, sebas<br /></div>


[Attachment #6 (text/plain)]

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin


[prev in list] [next in list] [prev in thread] [next in thread]