[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    [Differential] [Request, 7 lines] D1982: Validate activities in setOnActivities
From:       "davidedmundson (David Edmundson)" <noreply () phabricator ! kde ! org>
Date:       2016-06-23 15:05:34
Message-ID: differential-rev-PHID-DREV-txgziqathqgmoj5qfrpp-req () phabricator ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: KWin.
Restricted Application added a subscriber: kwin.

REVISION SUMMARY
  This fixes a bug I had where Session Management restored a window on an
  activity that didn't exist that, meaning I was unable to access it.
  
  setOnActivity() already has this check

TEST PLAN
  Using my broken session, restored and got my ghost process back 
  on all activities
  
  Added a window to activity 2, checked it came back there and 
  only there.

REPOSITORY
  rKWIN KWin

BRANCH
  Plasma/5.7

REVISION DETAIL
  https://phabricator.kde.org/D1982

AFFECTED FILES
  client.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma
Cc: kwin, hardening, jensreuterberg, sebas

[Attachment #5 (text/html)]

<table><tr><td style="">davidedmundson created this revision.<br />davidedmundson \
added a reviewer: Plasma.<br />Restricted Application added a project: KWin.<br \
/>Restricted Application added a subscriber: kwin.</td><a style="text-decoration: \
none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: \
bold; border-radius: 3px; background-color: #F7F7F9; background-image: \
linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid \
rgba(71,87,120,.2);" href="https://phabricator.kde.org/D1982" rel="noreferrer">View \
Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>This \
fixes a bug I had where Session Management restored a window on an<br /> activity \
that didn&#039;t exist that, meaning I was unable to access it.</p>

<p>setOnActivity() already has this check</p></div></div><br /><div><strong>TEST \
PLAN</strong><div><p>Using my broken session, restored and got my ghost process back \
<br /> on all activities</p>

<p>Added a window to activity 2, checked it came back there and <br />
only there.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>rKWIN \
KWin</div></div></div><br \
/><div><strong>BRANCH</strong><div><div>Plasma/5.7</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D1982" \
rel="noreferrer">https://phabricator.kde.org/D1982</a></div></div><br \
/><div><strong>AFFECTED FILES</strong><div><div>client.cpp</div></div></div><br \
/><div><strong>EMAIL PREFERENCES</strong><div><a \
href="https://phabricator.kde.org/settings/panel/emailpreferences/" \
rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br \
/><div><strong>To: </strong>davidedmundson, Plasma<br /><strong>Cc: </strong>kwin, \
hardening, jensreuterberg, sebas<br /></div>


[Attachment #6 (text/plain)]

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin


[prev in list] [next in list] [prev in thread] [next in thread]