[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request 127985: [effects] Do not try to opacify highlighted window
From: Thomas_Lübking <thomas.luebking () gmail ! com>
Date: 2016-05-27 9:35:44
Message-ID: 20160527093544.6029.21069 () mimi ! kde ! org
[Download RAW message or body]
--===============6903978009698323768==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127985/#review95910
-----------------------------------------------------------
minor stuff, but in general the right fix.
Please wait for a ShipIt from Martin - being a lame duck, I cannot legally provide \
that anymore.
deleted.h (line 58)
<https://git.reviewboard.kde.org/r/127985/#comment64873>
"virtual bool isCurrentTab() const override;"
deleted.cpp (line 44)
<https://git.reviewboard.kde.org/r/127985/#comment64874>
better default to true
- Thomas Lübking
On Mai 27, 2016, 3:51 vorm., Anthony Fieroni wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127985/
> -----------------------------------------------------------
>
> (Updated Mai 27, 2016, 3:51 vorm.)
>
>
> Review request for kwin, Martin Gräßlin and Thomas Lübking.
>
>
> Repository: kwin
>
>
> Description
> -------
>
> It's strange to me, why it is performed.
>
>
> Diffs
> -----
>
> abstract_client.h 4a65c2f
> abstract_client.cpp b323030
> deleted.h b89c961
> deleted.cpp 5e0225f
> libkwineffects/kwineffects.cpp 206afa3
> toplevel.h 3133851
> toplevel.cpp af368b5
>
> Diff: https://git.reviewboard.kde.org/r/127985/diff/
>
>
> Testing
> -------
>
> 1. Enable both tooltips and highlighted windows in taskmanager settings
> 2. Hover task in taskmanager
> 3. When tooltip appear move mouse cursor over it
> 4. Effect is stopped
> 5. Now move mouse cursor back to task item or over thumbnail window
> 6. Tooltip is opacified causing binking it
> 7. Make this move faster => annoying blinking tooltip
>
>
> Thanks,
>
> Anthony Fieroni
>
>
--===============6903978009698323768==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/127985/">https://git.reviewboard.kde.org/r/127985/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">minor \
stuff, but in general the right fix. Please wait for a ShipIt from Martin - being a \
lame duck, I cannot legally provide that anymore.</p></pre> <br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/127985/diff/6/?file=465526#file465526line58" \
style="color: black; font-weight: bold; text-decoration: underline;">deleted.h</a> \
<span style="font-weight: normal;">
(Diff revision 6)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">58</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">virtual</span> <span class="kt">bool</span> <span \
class="n">isCurrentTab</span><span class="p">()</span> <span \
class="k">const</span><span class="p">;</span></pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">"virtual bool isCurrentTab() const override;"</p></pre> </div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/127985/diff/6/?file=465527#file465527line44" \
style="color: black; font-weight: bold; text-decoration: underline;">deleted.cpp</a> \
<span style="font-weight: normal;">
(Diff revision 6)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">44</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="p">,</span> <span class="n">m_wasCurrentTab</span><span \
class="p">(</span><span class="nb">false</span><span class="p">)</span></pre></td> \
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">better default to true</p></pre> </div>
</div>
<br />
<p>- Thomas Lübking</p>
<br />
<p>On Mai 27th, 2016, 3:51 vorm. UTC, Anthony Fieroni wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for kwin, Martin Gräßlin and Thomas Lübking.</div>
<div>By Anthony Fieroni.</div>
<p style="color: grey;"><i>Updated Mai 27, 2016, 3:51 vorm.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kwin
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">It's strange to me, why it is performed.</p></pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><ol style="padding: 0;text-rendering: inherit;margin: 0 0 0 \
2em;line-height: inherit;white-space: normal;"> <li style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;">Enable both tooltips and \
highlighted windows in taskmanager settings</li> <li style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Hover \
task in taskmanager</li> <li style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: normal;">When tooltip appear move mouse cursor \
over it</li> <li style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: normal;">Effect is stopped</li> <li style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Now \
move mouse cursor back to task item or over thumbnail window</li> <li style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;">Tooltip is opacified causing binking it</li> <li style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Make \
this move faster => annoying blinking tooltip</li> </ol></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>abstract_client.h <span style="color: grey">(4a65c2f)</span></li>
<li>abstract_client.cpp <span style="color: grey">(b323030)</span></li>
<li>deleted.h <span style="color: grey">(b89c961)</span></li>
<li>deleted.cpp <span style="color: grey">(5e0225f)</span></li>
<li>libkwineffects/kwineffects.cpp <span style="color: grey">(206afa3)</span></li>
<li>toplevel.h <span style="color: grey">(3133851)</span></li>
<li>toplevel.cpp <span style="color: grey">(af368b5)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/127985/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============6903978009698323768==--
[Attachment #3 (text/plain)]
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic