'Re: Review Request 127631: [ksmserver] We must be sure that kwin process is ended'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Re: Review Request 127631: [ksmserver] We must be sure that kwin process is ended
From:       Anthony Fieroni <bvbfan () abv ! bg>
Date:       2016-04-15 16:33:11
Message-ID: 20160415163311.15182.15532 () mimi ! kde ! org
[Download RAW message or body]

--===============3505707803196927886==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127631/
-----------------------------------------------------------

(Updated Април 15, 2016, 7:33 след обяд)

Status
------

This change has been discarded.

Review request for kwin, Plasma, David Edmundson, Martin Gräßlin, and Thomas \
Lübking.

Repository: plasma-workspace

Description
-------

We must proceed with autoStart0 when kwin process is ended otherwise \
kwindowsystem::self() is nullptr. Every restored session app cannot use \
kwindowsystem. This depends of cpu speed, it can be faster enough to start wm before \
ksmserver restore apps and kwindowsystem will be usable.

Diffs
-----

  ksmserver/startup.cpp f118b55 

Diff: https://git.reviewboard.kde.org/r/127631/diff/

Testing
-------

It's needed to fix this bug -> https://git.reviewboard.kde.org/r/127216/
I don't know how to proceed if kwin fails to start in every way, can we process - i \
think not?

Thanks,

Anthony Fieroni

--===============3505707803196927886==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/127631/">https://git.reviewboard.kde.org/r/127631/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been \
discarded.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for kwin, Plasma, David Edmundson, Martin Gräßlin, and Thomas \
Lübking.</div> <div>By Anthony Fieroni.</div>

<p style="color: grey;"><i>Updated Април 15, 2016, 7:33 след \
обяд</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">We must proceed with autoStart0 when kwin process is \
ended otherwise kwindowsystem::self() is nullptr. Every restored session app cannot \
use kwindowsystem. This depends of cpu speed, it can be faster enough to start wm \
before ksmserver restore apps and kwindowsystem will be usable.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">It's needed to fix this bug -&gt; \
https://git.reviewboard.kde.org/r/127216/ I don't know how to proceed if kwin fails \
to start in every way, can we process - i think not?</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>ksmserver/startup.cpp <span style="color: grey">(f118b55)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/127631/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============3505707803196927886==--

[Attachment #3 (text/plain)]

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin

[prev in list] [next in list] [prev in thread] [next in thread] 