'Re: Review Request 127377: Do NOT use the direct window type'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Re: Review Request 127377: Do NOT use the direct window type
From:       Martin_Gräßlin <mgraesslin () kde ! org>
Date:       2016-03-15 13:38:04
Message-ID: 20160315133804.26442.205 () mimi ! kde ! org
[Download RAW message or body]

--===============0084142232490868170==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127377/#review93553
-----------------------------------------------------------

Ship it!

Ship It!

- Martin Gräßlin

On March 14, 2016, 11:05 p.m., Thomas Lübking wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127377/
> -----------------------------------------------------------
> 
> (Updated March 14, 2016, 11:05 p.m.)
> 
> 
> Review request for kwin and Martin Gräßlin.
> 
> 
> Bugs: 360140
> https://bugs.kde.org/show_bug.cgi?id=360140
> 
> 
> Repository: kwin
> 
> 
> Description
> -------
> 
> Deleted window types will be queried by effects and whenever they ask
> they most certainly want to hear the effective one, the direct one is
> a detail. Also I think commit fec2b6310282d9ca11d21b5ea66e2f3243ef1825
> got the fixed TODO wrong - especially the resulting type should be
> desired, not the real one.
> 
> BUG: 360140
> FIXED-IN: 5.6
> 
> 
> Diffs
> -----
> 
> deleted.cpp 5e0225f 
> 
> Diff: https://git.reviewboard.kde.org/r/127377/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Thomas Lübking
> 
> 

--===============0084142232490868170==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/127377/">https://git.reviewboard.kde.org/r/127377/</a>
  </td>
    </tr>
   </table>
   <br />

<p>

Ship it!

</p>

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre>  <br />

<p>- Martin Gräßlin</p>

<br />
<p>On March 14th, 2016, 11:05 p.m. CET, Thomas Lübking wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for kwin and Martin Gräßlin.</div>
<div>By Thomas Lübking.</div>

<p style="color: grey;"><i>Updated March 14, 2016, 11:05 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="https://bugs.kde.org/show_bug.cgi?id=360140">360140</a>

</div>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kwin
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Deleted window types will be queried by effects and whenever they ask  \
they most certainly want to hear the effective one, the direct one is  a detail. Also \
I think commit fec2b6310282d9ca11d21b5ea66e2f3243ef1825  got the fixed TODO wrong - \
especially the resulting type should be  desired, not the real one.

    BUG: 360140
    FIXED-IN: 5.6</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>deleted.cpp <span style="color: grey">(5e0225f)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/127377/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============0084142232490868170==--

[Attachment #3 (text/plain)]

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin

[prev in list] [next in list] [prev in thread] [next in thread] 