From kwin Mon Mar 14 22:05:07 2016 From: =?utf-8?q?Thomas_L=C3=BCbking?= Date: Mon, 14 Mar 2016 22:05:07 +0000 To: kwin Subject: Review Request 127377: Do NOT use the direct window type Message-Id: <20160314220507.22520.70526 () mimi ! kde ! org> X-MARC-Message: https://marc.info/?l=kwin&m=145799312110828 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============7351935600465020664==" --===============7351935600465020664== Content-Type: multipart/alternative; boundary="===============3801691866977775237==" --===============3801691866977775237== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127377/ ----------------------------------------------------------- Review request for kwin and Martin Gräßlin. Bugs: 360140 https://bugs.kde.org/show_bug.cgi?id=360140 Repository: kwin Description ------- Deleted window types will be queried by effects and whenever they ask they most certainly want to hear the effective one, the direct one is a detail. Also I think commit fec2b6310282d9ca11d21b5ea66e2f3243ef1825 got the fixed TODO wrong - especially the resulting type should be desired, not the real one. BUG: 360140 FIXED-IN: 5.6 Diffs ----- deleted.cpp 5e0225f Diff: https://git.reviewboard.kde.org/r/127377/diff/ Testing ------- Thanks, Thomas Lübking --===============3801691866977775237== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 8bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127377/

Review request for kwin and Martin Gräßlin.

By Thomas Lübking.

Bugs: 360140

Repository: kwin

Description

Deleted window types will be queried by effects and whenever they ask
    they most certainly want to hear the effective one, the direct one is
    a detail. Also I think commit fec2b6310282d9ca11d21b5ea66e2f3243ef1825
    got the fixed TODO wrong - especially the resulting type should be
    desired, not the real one.
    
    BUG: 360140
    FIXED-IN: 5.6

Diffs

deleted.cpp (5e0225f)

View Diff

--===============3801691866977775237==-- --===============7351935600465020664== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18Ka3dpbiBtYWls aW5nIGxpc3QKa3dpbkBrZGUub3JnCmh0dHBzOi8vbWFpbC5rZGUub3JnL21haWxtYW4vbGlzdGlu Zm8va3dpbgo= --===============7351935600465020664==--