[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request 127278: Introduce and use gl extension blacklist to handle function resolution wr
From: Thomas_Lübking <thomas.luebking () gmail ! com>
Date: 2016-03-08 0:02:03
Message-ID: 20160308000203.6298.71318 () mimi ! kde ! org
[Download RAW message or body]
--===============8800021264904819271==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
> On März 7, 2016, 11:29 vorm., Martin Gräßlin wrote:
> > glxbackend.cpp, lines 325-329
> > <https://git.reviewboard.kde.org/r/127278/diff/1/?file=447957#file447957line325>
> >
> > just as an idea: store it additionaly on a dynamic property on the qApp?
We'd then better go through two helper funcs to keep things consistent.
Assuming we want to maintain the ability to feed a list in as environment: what would \
be the benefit of the additional property (it's read only 3 times on initialising the \
extension lists)
- Thomas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127278/#review93255
-----------------------------------------------------------
On März 4, 2016, 3:55 nachm., Thomas Lübking wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127278/
> -----------------------------------------------------------
>
> (Updated März 4, 2016, 3:55 nachm.)
>
>
> Review request for kwin and Martin Gräßlin.
>
>
> Bugs: 360033 and cc
> https://bugs.kde.org/show_bug.cgi?id=360033
> https://bugs.kde.org/show_bug.cgi?id=cc
>
>
> Repository: kwin
>
>
> Description
> -------
>
> commit 64fa1f9ef392e26b4e2054bc3f2ca7d62c8949cb \
>
> blacklist GL_*_robustness unless robust context \
>
> optionally, we might skip the attrib query in \
> the function resolution \
>
> CCBUG: 360033 \
>
> commit b198f5bc29520558740611358f6b76620332f976 \
>
> support blacklisting GL extensions \
>
> while MESA has this as a stock and global feature, the nvidia blob \
> and maybe others don't - also this allows us to limit kwin \
> features w/o impacting QtQuick contexts
>
>
> Diffs
> -----
>
> glxbackend.cpp 32fea4d
> libkwineffects/kwinglutils.cpp bd84db7
>
> Diff: https://git.reviewboard.kde.org/r/127278/diff/
>
>
> Testing
> -------
>
> forcing blacklistRobustness to true entered the unrobust function resolution \
> (despite! a robust context was created!) No problems w/ the shadermanager, though \
> ...
>
> Thanks,
>
> Thomas Lübking
>
>
--===============8800021264904819271==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/127278/">https://git.reviewboard.kde.org/r/127278/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On März 7th, 2016, 11:29 vorm. UTC, <b>Martin \
Gräßlin</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/127278/diff/1/?file=447957#file447957line325" \
style="color: black; font-weight: bold; text-decoration: \
underline;">glxbackend.cpp</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">325</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="k">if</span> <span class="p">(</span><span \
class="n">blacklistRobustness</span><span class="p">)</span> <span \
class="p">{</span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">326</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">QList</span><span class="o"><</span><span \
class="n">QByteArray</span><span class="o">></span> <span \
class="n">blacklist</span> <span class="o">=</span> <span \
class="n">qgetenv</span><span class="p">(</span><span \
class="s">"KWIN_GL_EXT_BLACKLIST"</span><span class="p">).</span><span \
class="n">split</span><span class="p">(</span><span \
class="sc">','</span><span class="p">);</span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">327</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">blacklist</span> <span class="o"><<</span> <span \
class="n">QByteArrayLiteral</span><span class="p">(</span><span \
class="s">"GL_ARB_robustness"</span><span class="p">)</span> <span \
class="o"><<</span> <span class="n">QByteArrayLiteral</span><span \
class="p">(</span><span class="s">"GL_EXT_robustness"</span><span \
class="p">);</span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">328</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">qputenv</span><span class="p">(</span><span \
class="s">"KWIN_GL_EXT_BLACKLIST"</span><span class="p">,</span> <span \
class="n">blacklist</span><span class="p">.</span><span class="n">join</span><span \
class="p">(</span><span class="sc">','</span><span \
class="p">));</span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">329</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="p">}</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">just \
as an idea: store it additionaly on a dynamic property on the qApp?</p></pre> \
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">We'd then better go through two helper funcs to keep things consistent. \
Assuming we want to maintain the ability to feed a list in as environment: what would \
be the benefit of the additional property (it's read only 3 times on initialising the \
extension lists)</p></pre> <br />
<p>- Thomas</p>
<br />
<p>On März 4th, 2016, 3:55 nachm. UTC, Thomas Lübking wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for kwin and Martin Gräßlin.</div>
<div>By Thomas Lübking.</div>
<p style="color: grey;"><i>Updated März 4, 2016, 3:55 nachm.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=360033">360033</a>,
<a href="https://bugs.kde.org/show_bug.cgi?id=cc">cc</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kwin
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">commit 64fa1f9ef392e26b4e2054bc3f2ca7d62c8949cb \
blacklist GL_*_robustness unless robust context \
optionally, we might skip the attrib query in \
the function resolution \
CCBUG: 360033 \
commit b198f5bc29520558740611358f6b76620332f976 \
support blacklisting GL extensions \
while MESA has this as a stock and global feature, the nvidia blob \
and maybe others don't - also this allows us to limit kwin \
features w/o impacting QtQuick contexts</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">forcing blacklistRobustness to true entered the \
unrobust function resolution (despite! a robust context was created!) No problems w/ \
the shadermanager, though ...</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>glxbackend.cpp <span style="color: grey">(32fea4d)</span></li>
<li>libkwineffects/kwinglutils.cpp <span style="color: grey">(bd84db7)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/127278/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============8800021264904819271==--
[Attachment #3 (text/plain)]
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic