[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request 127276: use a global static for animation ids
From: Marco Martin <notmart () gmail ! com>
Date: 2016-03-04 17:19:46
Message-ID: 20160304171946.32153.44157 () mimi ! kde ! org
[Download RAW message or body]
--===============8062173367799302499==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127276/
-----------------------------------------------------------
(Updated March 4, 2016, 5:19 p.m.)
Status
------
This change has been marked as submitted.
Review request for kwin.
Changes
-------
Submitted with commit 595c5937c9a1e13bdeed2759034ed66d8c89d614 by Marco Martin to \
branch master.
Bugs: 352254 and 360068
https://bugs.kde.org/show_bug.cgi?id=352254
https://bugs.kde.org/show_bug.cgi?id=360068
Repository: kwin
Description
-------
using stack adresses makes it possible (even tough not frequent) for two animations \
(onle just killed, one just created) to have the same id, causing scripts to be \
potentially really confused. this replaces the id with a global counter, and the \
"flying tooltips" bug is gone.
Diffs
-----
libkwineffects/anidata_p.h 75c7f47
libkwineffects/kwinanimationeffect.cpp 15ab44e
Diff: https://git.reviewboard.kde.org/r/127276/diff/
Testing
-------
Thanks,
Marco Martin
--===============8062173367799302499==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/127276/">https://git.reviewboard.kde.org/r/127276/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for kwin.</div>
<div>By Marco Martin.</div>
<p style="color: grey;"><i>Updated March 4, 2016, 5:19 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Submitted with commit 595c5937c9a1e13bdeed2759034ed66d8c89d614 by Marco \
Martin to branch master.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=352254">352254</a>,
<a href="https://bugs.kde.org/show_bug.cgi?id=360068">360068</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kwin
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">using stack adresses makes it possible (even tough not \
frequent) for two animations (onle just killed, one just created) to have the same \
id, causing scripts to be potentially really confused. this replaces the id with a \
global counter, and the "flying tooltips" bug is gone.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libkwineffects/anidata_p.h <span style="color: grey">(75c7f47)</span></li>
<li>libkwineffects/kwinanimationeffect.cpp <span style="color: \
grey">(15ab44e)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/127276/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============8062173367799302499==--
[Attachment #3 (text/plain)]
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic