[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request 127276: use a global static for animation ids
From: Thomas_Lübking <thomas.luebking () gmail ! com>
Date: 2016-03-04 15:30:21
Message-ID: 20160304153021.32153.80585 () mimi ! kde ! org
[Download RAW message or body]
--===============4414090750939197910==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127276/#review93159
-----------------------------------------------------------
libkwineffects/anidata_p.h (line 42)
<https://git.reviewboard.kde.org/r/127276/#comment63523>
it still should be initialized - no idea whether we may use declaration init \
(c++11 feature, "quint64 id{0};")
- Thomas Lübking
On March 4, 2016, 2:37 p.m., Marco Martin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127276/
> -----------------------------------------------------------
>
> (Updated March 4, 2016, 2:37 p.m.)
>
>
> Review request for kwin.
>
>
> Bugs: 352254 and 360068
> https://bugs.kde.org/show_bug.cgi?id=352254
> https://bugs.kde.org/show_bug.cgi?id=360068
>
>
> Repository: kwin
>
>
> Description
> -------
>
> using stack adresses makes it possible (even tough not frequent) for two animations \
> (onle just killed, one just created) to have the same id, causing scripts to be \
> potentially really confused. this replaces the id with a global counter, and the \
> "flying tooltips" bug is gone.
>
> Diffs
> -----
>
> libkwineffects/anidata_p.h 75c7f47
> libkwineffects/kwinanimationeffect.cpp 15ab44e
>
> Diff: https://git.reviewboard.kde.org/r/127276/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Marco Martin
>
>
--===============4414090750939197910==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/127276/">https://git.reviewboard.kde.org/r/127276/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/127276/diff/2/?file=447953#file447953line42" \
style="color: black; font-weight: bold; text-decoration: \
underline;">libkwineffects/anidata_p.h</a> <span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">42</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">quint64</span> <span class="n">id</span><span class="p">;</span></pre></td> \
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">it \
still should be initialized - no idea whether we may use declaration init (c++11 \
feature, "quint64 id{0};")</p></pre> </div>
</div>
<br />
<p>- Thomas Lübking</p>
<br />
<p>On March 4th, 2016, 2:37 p.m. UTC, Marco Martin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for kwin.</div>
<div>By Marco Martin.</div>
<p style="color: grey;"><i>Updated March 4, 2016, 2:37 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=352254">352254</a>,
<a href="https://bugs.kde.org/show_bug.cgi?id=360068">360068</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kwin
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">using stack adresses makes it possible (even tough not \
frequent) for two animations (onle just killed, one just created) to have the same \
id, causing scripts to be potentially really confused. this replaces the id with a \
global counter, and the "flying tooltips" bug is gone.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libkwineffects/anidata_p.h <span style="color: grey">(75c7f47)</span></li>
<li>libkwineffects/kwinanimationeffect.cpp <span style="color: \
grey">(15ab44e)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/127276/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============4414090750939197910==--
[Attachment #3 (text/plain)]
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic