[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request 125933: Optimize string operations
From: "Nick Shaforostoff" <shafff () ukr ! net>
Date: 2015-11-05 14:22:19
Message-ID: 20151105142219.24343.26190 () mimi ! kde ! org
[Download RAW message or body]
--===============0725190277181183273==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125933/
-----------------------------------------------------------
(Updated Nov. 5, 2015, 2:22 p.m.)
Status
------
This change has been marked as submitted.
Review request for kwin and Martin Gräßlin.
Changes
-------
Submitted with commit 3a8d7d866ada5f24fc7313bfd094a076943ec8ce by Nick Shaforostoff \
to branch master.
Repository: kwin
Description
-------
I have changed the code to use QByteArray in many places (to avoid 8->16->8 \
converting with the data that is expected to be Latin1 only), and QStringRef in few \
others. For comparing strings QLatin1String performs better than QStringLiteral.
One AniData ctor was missing windowType member initialization so i have zeroed it.
Also this patch contains fix for Coverity issue #1291360:
https://scan5.coverity.com/reports.htm#v39099/p10103/fileInstanceId=82671774&defectInstanceId=24554425&mergedDefectId=1291360
(missing initialization for can_wobble_*)
Diffs
-----
CMakeLists.txt 369f9c4
autotests/CMakeLists.txt b751f53
client.cpp 2488317
clients/aurorae/src/aurorae.cpp 781c960
clients/aurorae/src/lib/auroraetheme.cpp ed940a0
composite.cpp 70f2e13
compositingprefs.cpp bb83d45
dbusinterface.cpp 9392808
effects.cpp 992760d
kcmkwin/kwinrules/detectwidget.cpp 2e855b3
kcmkwin/kwintabbox/main.cpp a97bdfa
libkwineffects/anidata.cpp 81ad976
libkwineffects/anidata_p.h 75c7f47
libkwineffects/kwinanimationeffect.h 0384c71
libkwineffects/kwinanimationeffect.cpp ab4313e
libkwineffects/kwineffects.cpp 33e295c
libkwineffects/kwinglplatform.h 0e96be9
libkwineffects/kwinglplatform.cpp 1d8bb4f
libkwineffects/kwingltexture.cpp 5f84dd6
libkwineffects/kwinglutils.cpp 902e4ad
main_wayland.cpp fc09aa7
outline.cpp 252e39a
rules.cpp fe449e6
scene_opengl.cpp e0efcac
scripting/genericscriptedconfig.cpp 9c1798a
scripting/scriptedeffect.cpp 0c4abc9
scripting/scripting.cpp 8e32968
sm.cpp 087782d
tabbox/tabboxhandler.cpp b4f1713
useractions.cpp 87e93e1
Diff: https://git.reviewboard.kde.org/r/125933/diff/
Testing
-------
compiles fine. i expect that the reviewer will check that the code doesn't break \
anything in the runtime (it shouldn't but who knows)
Thanks,
Nick Shaforostoff
--===============0725190277181183273==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/125933/">https://git.reviewboard.kde.org/r/125933/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for kwin and Martin Gräßlin.</div>
<div>By Nick Shaforostoff.</div>
<p style="color: grey;"><i>Updated Nov. 5, 2015, 2:22 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Submitted with commit 3a8d7d866ada5f24fc7313bfd094a076943ec8ce by Nick \
Shaforostoff to branch master.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kwin
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I have changed the code to use QByteArray in many places (to avoid \
8->16->8 converting with the data that is expected to be Latin1 only), and \
QStringRef in few others. For comparing strings QLatin1String performs better than \
QStringLiteral.
One AniData ctor was missing windowType member initialization so i have zeroed it.
Also this patch contains fix for Coverity issue #1291360:
https://scan5.coverity.com/reports.htm#v39099/p10103/fileInstanceId=82671774&defectInstanceId=24554425&mergedDefectId=1291360
(missing initialization for can_wobble_*)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">compiles fine. i expect that the reviewer will check \
that the code doesn't break anything in the runtime (it shouldn't but who \
knows)</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(369f9c4)</span></li>
<li>autotests/CMakeLists.txt <span style="color: grey">(b751f53)</span></li>
<li>client.cpp <span style="color: grey">(2488317)</span></li>
<li>clients/aurorae/src/aurorae.cpp <span style="color: grey">(781c960)</span></li>
<li>clients/aurorae/src/lib/auroraetheme.cpp <span style="color: \
grey">(ed940a0)</span></li>
<li>composite.cpp <span style="color: grey">(70f2e13)</span></li>
<li>compositingprefs.cpp <span style="color: grey">(bb83d45)</span></li>
<li>dbusinterface.cpp <span style="color: grey">(9392808)</span></li>
<li>effects.cpp <span style="color: grey">(992760d)</span></li>
<li>kcmkwin/kwinrules/detectwidget.cpp <span style="color: \
grey">(2e855b3)</span></li>
<li>kcmkwin/kwintabbox/main.cpp <span style="color: grey">(a97bdfa)</span></li>
<li>libkwineffects/anidata.cpp <span style="color: grey">(81ad976)</span></li>
<li>libkwineffects/anidata_p.h <span style="color: grey">(75c7f47)</span></li>
<li>libkwineffects/kwinanimationeffect.h <span style="color: \
grey">(0384c71)</span></li>
<li>libkwineffects/kwinanimationeffect.cpp <span style="color: \
grey">(ab4313e)</span></li>
<li>libkwineffects/kwineffects.cpp <span style="color: grey">(33e295c)</span></li>
<li>libkwineffects/kwinglplatform.h <span style="color: grey">(0e96be9)</span></li>
<li>libkwineffects/kwinglplatform.cpp <span style="color: \
grey">(1d8bb4f)</span></li>
<li>libkwineffects/kwingltexture.cpp <span style="color: grey">(5f84dd6)</span></li>
<li>libkwineffects/kwinglutils.cpp <span style="color: grey">(902e4ad)</span></li>
<li>main_wayland.cpp <span style="color: grey">(fc09aa7)</span></li>
<li>outline.cpp <span style="color: grey">(252e39a)</span></li>
<li>rules.cpp <span style="color: grey">(fe449e6)</span></li>
<li>scene_opengl.cpp <span style="color: grey">(e0efcac)</span></li>
<li>scripting/genericscriptedconfig.cpp <span style="color: \
grey">(9c1798a)</span></li>
<li>scripting/scriptedeffect.cpp <span style="color: grey">(0c4abc9)</span></li>
<li>scripting/scripting.cpp <span style="color: grey">(8e32968)</span></li>
<li>sm.cpp <span style="color: grey">(087782d)</span></li>
<li>tabbox/tabboxhandler.cpp <span style="color: grey">(b4f1713)</span></li>
<li>useractions.cpp <span style="color: grey">(87e93e1)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/125933/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============0725190277181183273==--
[Attachment #3 (text/plain)]
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic