'Re: Review Request 125871: WIP: task geometries to wayland for minimize effect'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Re: Review Request 125871: WIP: task geometries to wayland for minimize effect
From:       "Marco Martin" <notmart () gmail ! com>
Date:       2015-11-04 16:34:31
Message-ID: 20151104163431.24343.50492 () mimi ! kde ! org
[Download RAW message or body]

--===============1004161845667306480==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

On Nov. 4, 2015, 4:15 p.m., Marco Martin wrote:
> > sorry for the post review (and in case this has been addressed for the ultimate \
> > commt)

last commit on master should address those comments

- Marco

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125871/#review88016
-----------------------------------------------------------

On Nov. 4, 2015, 12:21 p.m., Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125871/
> -----------------------------------------------------------
> 
> (Updated Nov. 4, 2015, 12:21 p.m.)
> 
> 
> Review request for kwin and Plasma.
> 
> 
> Repository: kwayland
> 
> 
> Description
> -------
> 
> this exposes the geometry of taskbar entries in plasma-windowmanagement, in order \
> to make the minimize effects possible. unlike on X11, it takes relative positions \
> and it has one geometry per panel, making possible to have multiple taskbars \
> working. 
> however this is still not completely exposed, as internally kwin has still only one \
> geometry, it will need a change in kwin itself (suggestions welcome) probably the \
> rotocol will need also a minimizeTo function that takes the panel as argument. 
> another thing completely missing is tests: unfortunately the whole \
> plasma-windowmanagement doesn't have any autotest yet :/ 
> 
> Diffs
> -----
> 
> src/client/plasmawindowmanagement.cpp 1f9674c 
> src/client/plasmawindowmanagement.h abd8fa6 
> autotests/client/test_wayland_windowmanagement.cpp PRE-CREATION 
> autotests/client/CMakeLists.txt 1556c47 
> src/client/plasmawindowmodel.h 5a6aac4 
> src/client/plasmawindowmodel.cpp 355ef53 
> src/client/protocols/plasma-window-management.xml ca6a7cc 
> src/server/plasmawindowmanagement_interface.h 6ccc22e 
> src/server/plasmawindowmanagement_interface.cpp ad714a5 
> 
> Diff: https://git.reviewboard.kde.org/r/125871/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marco Martin
> 
> 

--===============1004161845667306480==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/125871/">https://git.reviewboard.kde.org/r/125871/</a>
  </td>
    </tr>
   </table>
   <br />

<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <p style="margin-top: 0;">On November 4th, 2015, 4:15 p.m. UTC, <b>Thomas \
Lübking</b> wrote:</p>  <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">  <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">sorry for the post review (and in case this has been \
addressed for the ultimate commt)</p></pre>  </blockquote>

</blockquote>

<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">last \
commit on master should address those comments</p></pre> <br />

<p>- Marco</p>

<br />
<p>On November 4th, 2015, 12:21 p.m. UTC, Marco Martin wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for kwin and Plasma.</div>
<div>By Marco Martin.</div>

<p style="color: grey;"><i>Updated Nov. 4, 2015, 12:21 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kwayland
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">this exposes the geometry of taskbar entries in \
plasma-windowmanagement, in order to make the minimize effects possible. unlike on \
X11, it takes relative positions and it has one geometry per panel, making possible \
to have multiple taskbars working.</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">however this is still \
not completely exposed, as internally kwin has still only one geometry, it will need \
a change in kwin itself (suggestions welcome) probably the rotocol will need also a \
minimizeTo function that takes the panel as argument.</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">another thing completely missing is tests: unfortunately the whole \
plasma-windowmanagement doesn't have any autotest yet :/</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/client/plasmawindowmanagement.cpp <span style="color: \
grey">(1f9674c)</span></li>

 <li>src/client/plasmawindowmanagement.h <span style="color: \
grey">(abd8fa6)</span></li>

 <li>autotests/client/test_wayland_windowmanagement.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>autotests/client/CMakeLists.txt <span style="color: grey">(1556c47)</span></li>

 <li>src/client/plasmawindowmodel.h <span style="color: grey">(5a6aac4)</span></li>

 <li>src/client/plasmawindowmodel.cpp <span style="color: grey">(355ef53)</span></li>

 <li>src/client/protocols/plasma-window-management.xml <span style="color: \
grey">(ca6a7cc)</span></li>

 <li>src/server/plasmawindowmanagement_interface.h <span style="color: \
grey">(6ccc22e)</span></li>

 <li>src/server/plasmawindowmanagement_interface.cpp <span style="color: \
grey">(ad714a5)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/125871/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============1004161845667306480==--

[Attachment #3 (text/plain)]

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin

[prev in list] [next in list] [prev in thread] [next in thread] 