[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request 125453: introduce SkipsTaskbar
From: Martin_Gräßlin <mgraesslin () kde ! org>
Date: 2015-09-30 11:03:31
Message-ID: 20150930110331.16344.79767 () mimi ! kde ! org
[Download RAW message or body]
--===============3709286966663855402==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125453/#review86150
-----------------------------------------------------------
Ship it!
src/client/plasmashell.h (lines 249 - 250)
<https://git.reviewboard.kde.org/r/125453/#comment59405>
please add @since 5.5 also on the client
- Martin Gräßlin
On Sept. 30, 2015, 12:28 p.m., Marco Martin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125453/
> -----------------------------------------------------------
>
> (Updated Sept. 30, 2015, 12:28 p.m.)
>
>
> Review request for kwin and Plasma.
>
>
> Repository: kwayland
>
>
> Description
> -------
>
> support the skiptTaskbar property in the window model
> that property is set client side by
> PlasmaShell::setSkipsTaskbar
>
>
> Diffs
> -----
>
> src/client/plasmawindowmanagement.h 6e36def
> src/client/plasmashell.h 6692300
> src/client/plasmashell.cpp 4daaecf
> src/client/plasmawindowmanagement.cpp f6279d9
> src/client/plasmawindowmodel.h 49a2115
> src/client/plasmawindowmodel.cpp ceba6ce
> src/client/protocols/plasma-shell.xml 7d33236
> src/client/protocols/plasma-window-management.xml a5bd639
> src/client/registry.cpp 9fa6f64
> src/server/plasmashell_interface.h 228cbb1
> src/server/plasmashell_interface.cpp 32fd389
> src/server/plasmawindowmanagement_interface.h c348d65
> src/server/plasmawindowmanagement_interface.cpp d6c71ae
>
> Diff: https://git.reviewboard.kde.org/r/125453/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Marco Martin
>
>
--===============3709286966663855402==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/125453/">https://git.reviewboard.kde.org/r/125453/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/125453/diff/3/?file=408827#file408827line249" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/client/plasmashell.h</a> <span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
">public:</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">249</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="kt">void</span> <span class="nf">setSkipTaskbar</span><span \
class="p">(</span><span class="kt">bool</span> <span class="n">skip</span><span \
class="p">);</span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">250</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> \
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">please add @since 5.5 also on the client</p></pre> </div>
</div>
<br />
<p>- Martin Gräßlin</p>
<br />
<p>On September 30th, 2015, 12:28 p.m. CEST, Marco Martin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for kwin and Plasma.</div>
<div>By Marco Martin.</div>
<p style="color: grey;"><i>Updated Sept. 30, 2015, 12:28 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kwayland
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">support the skiptTaskbar property in the window model that property is \
set client side by PlasmaShell::setSkipsTaskbar</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/client/plasmawindowmanagement.h <span style="color: \
grey">(6e36def)</span></li>
<li>src/client/plasmashell.h <span style="color: grey">(6692300)</span></li>
<li>src/client/plasmashell.cpp <span style="color: grey">(4daaecf)</span></li>
<li>src/client/plasmawindowmanagement.cpp <span style="color: \
grey">(f6279d9)</span></li>
<li>src/client/plasmawindowmodel.h <span style="color: grey">(49a2115)</span></li>
<li>src/client/plasmawindowmodel.cpp <span style="color: grey">(ceba6ce)</span></li>
<li>src/client/protocols/plasma-shell.xml <span style="color: \
grey">(7d33236)</span></li>
<li>src/client/protocols/plasma-window-management.xml <span style="color: \
grey">(a5bd639)</span></li>
<li>src/client/registry.cpp <span style="color: grey">(9fa6f64)</span></li>
<li>src/server/plasmashell_interface.h <span style="color: \
grey">(228cbb1)</span></li>
<li>src/server/plasmashell_interface.cpp <span style="color: \
grey">(32fd389)</span></li>
<li>src/server/plasmawindowmanagement_interface.h <span style="color: \
grey">(c348d65)</span></li>
<li>src/server/plasmawindowmanagement_interface.cpp <span style="color: \
grey">(d6c71ae)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/125453/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============3709286966663855402==--
[Attachment #3 (text/plain)]
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic