'Re: Review Request 122577: Windows retain their assigned activities on kwin restart'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Re: Review Request 122577: Windows retain their assigned activities on kwin restart
From:       "Elias Probst" <mail () eliasprobst ! eu>
Date:       2015-02-15 22:03:25
Message-ID: 20150215220325.4989.71993 () probe ! kde ! org
[Download RAW message or body]

--===============0281336073240413018==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122577/#review76078
-----------------------------------------------------------

Ship it!

From a functionality POV it works as expected! All windows restored on their correct \
activity when restarting kwin.

Thanks a lot!

- Elias Probst

On Feb. 15, 2015, 3:04 p.m., Ivan Čukić wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122577/
> -----------------------------------------------------------
> 
> (Updated Feb. 15, 2015, 3:04 p.m.)
> 
> 
> Review request for kwin, Elias Probst and Martin Gräßlin.
> 
> 
> Repository: kwin
> 
> 
> Description
> -------
> 
> The issue is essentially this - KActivities are now an asynchonous library, while \
> KWin tries to use them in the old manner. 
> When kwin restarts, it tries to validate the activity list of a window against an \
> invalid list of activities it thinks it gets from KAMD because it does not check \
> for the service status. 
> This patch disables the validation in the case of kwin restart/crash. When starting \
> kwin will see KActivities::Consumer::serviceStatus return Unknown (before the class \
> actually receives a response from the service and starts syncing the data). 
> After kwin has started, the response will arrive and the service status will change \
> either to Running or NotRunning. The patch changes nothing for this case. 
> This is bug 335967
> 
> 
> Diffs
> -----
> 
> activities.h 0ec02b6 
> activities.cpp 01a6329 
> client.cpp 3e834f2 
> 
> Diff: https://git.reviewboard.kde.org/r/122577/diff/
> 
> 
> Testing
> -------
> 
> Windows on one, two or all activities remain on those after restart.
> 
> 
> Thanks,
> 
> Ivan Čukić
> 
> 

--===============0281336073240413018==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/122577/">https://git.reviewboard.kde.org/r/122577/</a>
  </td>
    </tr>
   </table>
   <br />

 <p>Ship it!</p>

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">From \
a functionality POV it works as expected! All windows restored on their correct \
activity when restarting kwin.</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">Thanks a lot!</p></pre> \
<br />

<p>- Elias Probst</p>

<br />
<p>On February 15th, 2015, 3:04 p.m. UTC, Ivan Čukić wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for kwin, Elias Probst and Martin Gräßlin.</div>
<div>By Ivan Čukić.</div>

<p style="color: grey;"><i>Updated Feb. 15, 2015, 3:04 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kwin
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">The issue is essentially this - KActivities are now an \
asynchonous library, while KWin tries to use them in the old manner.</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">When kwin restarts, it tries to validate the activity list of a window \
against an invalid list of activities it thinks it gets from KAMD because it does not \
check for the service status.</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">This patch disables the \
validation in the case of kwin restart/crash. When starting kwin will see \
KActivities::Consumer::serviceStatus return Unknown (before the class actually \
receives a response from the service and starts syncing the data).</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">After kwin has started, the response will arrive and the service status \
will change either to Running or NotRunning. The patch changes nothing for this \
case.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This is bug 335967</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Windows on one, two or all activities remain on those \
after restart.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>activities.h <span style="color: grey">(0ec02b6)</span></li>

 <li>activities.cpp <span style="color: grey">(01a6329)</span></li>

 <li>client.cpp <span style="color: grey">(3e834f2)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/122577/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============0281336073240413018==--

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin

[prev in list] [next in list] [prev in thread] [next in thread] 