'Re: Review Request 122342: Don't let notification popup accept focus'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Re: Review Request 122342: Don't let notification popup accept focus
From:       "Martin Klapetek" <martin.klapetek () gmail ! com>
Date:       2015-02-02 11:22:44
Message-ID: 20150202112244.19248.78458 () probe ! kde ! org
[Download RAW message or body]

--===============8112374133912167487==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122342/#review75200
-----------------------------------------------------------

Ship it!

Thanks!! Also I think there's a bug opened for this (by you even?) so please close it \
too

- Martin Klapetek

On Jan. 31, 2015, 7:44 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122342/
> -----------------------------------------------------------
> 
> (Updated Jan. 31, 2015, 7:44 p.m.)
> 
> 
> Review request for kwin, Plasma and Martin Klapetek.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> This fixes eg. the systray popup closing when closing a notification. Thanks Thomas \
> for spotting this. 
> 
> Diffs
> -----
> 
> applets/notifications/package/contents/ui/NotificationPopup.qml 05cb4e7 
> 
> Diff: https://git.reviewboard.kde.org/r/122342/diff/
> 
> 
> Testing
> -------
> 
> Popups no longer close, windows no longer lose focus, when interacting with a \
> notification popup. I can still close them or click on action buttons. Makes them \
> waaaaaay less painful and annoying. 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
> 

--===============8112374133912167487==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/122342/">https://git.reviewboard.kde.org/r/122342/</a>
  </td>
    </tr>
   </table>
   <br />

 <p>Ship it!</p>

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Thanks!! Also I think there's a bug opened for this (by you even?) so \
please close it too</p></pre>  <br />

<p>- Martin Klapetek</p>

<br />
<p>On January 31st, 2015, 7:44 p.m. CET, Kai Uwe Broulik wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for kwin, Plasma and Martin Klapetek.</div>
<div>By Kai Uwe Broulik.</div>

<p style="color: grey;"><i>Updated Jan. 31, 2015, 7:44 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This fixes eg. the systray popup closing when closing \
a notification. Thanks Thomas for spotting this.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Popups no longer close, windows no longer lose focus, \
when interacting with a notification popup. I can still close them or click on action \
buttons. Makes them waaaaaay less painful and annoying.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>applets/notifications/package/contents/ui/NotificationPopup.qml <span \
style="color: grey">(05cb4e7)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/122342/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============8112374133912167487==--

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin

[prev in list] [next in list] [prev in thread] [next in thread] 