[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request 122170: [kcmkwin/tabbox] Improve locating the services used in preview mode
From: "Elias Probst" <mail () eliasprobst ! eu>
Date: 2015-01-20 14:48:05
Message-ID: 20150120144805.32442.21080 () probe ! kde ! org
[Download RAW message or body]
--===============0626395175537458168==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122170/#review74391
-----------------------------------------------------------
Ship it!
Looks good! The previews work as expected.
I don't really have an idea regarding systemsettings either - any other standard \
application we could query through the assigned mime-type which could be used \
instead?
- Elias Probst
On Jan. 20, 2015, 2:24 p.m., Martin Gräßlin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122170/
> -----------------------------------------------------------
>
> (Updated Jan. 20, 2015, 2:24 p.m.)
>
>
> Review request for kwin and Elias Probst.
>
>
> Bugs: 310622
> https://bugs.kde.org/show_bug.cgi?id=310622
>
>
> Repository: kwin
>
>
> Description
> -------
>
> Instead of hard coding the desktop files, let's try to use what the
> user actually uses.
> * Browser mapped from text/html mime type
> * File manager mapped from inode/directory mime type
> * Email client mapped from message/rfc822 mime type
>
> Only systemsettings is "hard coded" as there is no mime type to map.
>
> The thumbnails are not changed, though. But they are so small that
> it's hardly recognizable anyway. For future it could be considered to
> map against appdata to get a better screenshot.
>
> BUG: 310622
>
>
> Diffs
> -----
>
> kcmkwin/kwintabbox/layoutpreview.h 8180d34589b079d3cfa278ce13c5f3a3d205ca6a
> kcmkwin/kwintabbox/layoutpreview.cpp 87ed1baea14ae46ea1ba72069102a1085ad3a8a3
>
> Diff: https://git.reviewboard.kde.org/r/122170/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Martin Gräßlin
>
>
--===============0626395175537458168==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/122170/">https://git.reviewboard.kde.org/r/122170/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Looks \
good! The previews work as expected.</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">I don't really have an \
idea regarding systemsettings either - any other standard application we could query \
through the assigned mime-type which could be used instead?</p></pre> <br />
<p>- Elias Probst</p>
<br />
<p>On January 20th, 2015, 2:24 p.m. UTC, Martin Gräßlin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for kwin and Elias Probst.</div>
<div>By Martin Gräßlin.</div>
<p style="color: grey;"><i>Updated Jan. 20, 2015, 2:24 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=310622">310622</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kwin
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Instead of hard coding the desktop files, let's try to use what the \
user actually uses.
* Browser mapped from text/html mime type
* File manager mapped from inode/directory mime type
* Email client mapped from message/rfc822 mime type
Only systemsettings is "hard coded" as there is no mime type to map.
The thumbnails are not changed, though. But they are so small that
it's hardly recognizable anyway. For future it could be considered to
map against appdata to get a better screenshot.
BUG: 310622</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kcmkwin/kwintabbox/layoutpreview.h <span style="color: \
grey">(8180d34589b079d3cfa278ce13c5f3a3d205ca6a)</span></li>
<li>kcmkwin/kwintabbox/layoutpreview.cpp <span style="color: \
grey">(87ed1baea14ae46ea1ba72069102a1085ad3a8a3)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/122170/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============0626395175537458168==--
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic