[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request 121957: Deprecate kservice_desktop_to_json(), use kcoreaddons_desktop_to_json().
From: "Elias Probst" <mail () eliasprobst ! eu>
Date: 2015-01-16 21:54:40
Message-ID: 20150116215440.19346.35260 () probe ! kde ! org
[Download RAW message or body]
--===============1435747396848740663==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121957/
-----------------------------------------------------------
(Updated Jan. 16, 2015, 9:54 p.m.)
Status
------
This change has been marked as submitted.
Review request for kwin.
Repository: kwin
Description
-------
Deprecate `kservice_desktop_to_json()`, use `kcoreaddons_desktop_to_json()` instead.
Get rid of deprecation warnings in effects KCM.
Diffs
-----
effects/blur/CMakeLists.txt afe5b65f134ce96cb3060fc8e9bdfbc5a990670f
effects/coverswitch/CMakeLists.txt 691faf43e5c9b0e43819ca08cb081f1c09119e83
effects/cube/CMakeLists.txt 2562689526d181e73fbbca26490611d06123a644
effects/dashboard/CMakeLists.txt d55d16c21ef09f3be763a1ec534dabcf419834f2
effects/desktopgrid/CMakeLists.txt 4764374359060c932c4ce8b38f89cb919db5cfb0
effects/diminactive/CMakeLists.txt 221bc8fc0f4cd16f55d0d1bf3519f43919b139f8
effects/flipswitch/CMakeLists.txt a0d011ea4be8911363df0ea30b317bbc32cbc924
effects/glide/CMakeLists.txt 9f8c47ffb74c657bcb86fd9829a150f2aac75867
effects/invert/CMakeLists.txt 9d637fb583ea4d5fa4c189b0f90f0f3ee72dbb56
effects/lookingglass/CMakeLists.txt 796697e494263fa8870d29fd1908306265733fa7
effects/magiclamp/CMakeLists.txt 5227f1ded8572ccf32eb64e1d171db5c30f6b7e2
effects/magnifier/CMakeLists.txt 6a43377176f810d0a7aba07a4c216d2d82a6b5c1
effects/mouseclick/CMakeLists.txt 251e8e744879634920c7ed93d6301fa8ef581eb2
effects/mousemark/CMakeLists.txt 71e20bad62e642b946faacc838bc4150e388bf82
effects/presentwindows/CMakeLists.txt 10e6a0b91cb745f8b384004c656bfea49fc20ab3
effects/resize/CMakeLists.txt 0f6b442a98db0eeb601858132e8124a1cb02b909
effects/showfps/CMakeLists.txt c8de55ba1ca5405097d28a40171793d2a3bc5418
effects/thumbnailaside/CMakeLists.txt 8cd89a2fdae510157b7bff3f56032e6357c2a9f0
effects/trackmouse/CMakeLists.txt 3e68bea37b4f380f889cd9860e64997808b765da
effects/windowgeometry/CMakeLists.txt bbf2fc691c021e050168f09fb7df51b5c1ae8944
effects/wobblywindows/CMakeLists.txt a2db98fc2d8dcdd049f0c63d42168ae6ce9a3547
effects/zoom/CMakeLists.txt 7a86c08e4dcc2ca67c715db9efc1f14967bf8784
Diff: https://git.reviewboard.kde.org/r/121957/diff/
Testing
-------
Effects KCM still works as expected - all effects load and can be used.
Nearly all deprecation warnings regarding `kservice_desktop_to_json()` are gone now \
in effects KCM.
There's only one remaining:
```
Constructing a KPluginInfo object from old style JSON. Please use \
kcoreaddons_desktop_to_json() for \
"/usr/lib64/qt5/plugins/kwin/effects/configs/kcm_kwin4_genericscripted.so" instead of \
kservice_desktop_to_json() in your CMake code. ```
I couldn't find out so far why `kcm_kwin4_genericscripted.so` is still processed \
using `kservice_desktop_to_json()`.
Thanks,
Elias Probst
--===============1435747396848740663==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/121957/">https://git.reviewboard.kde.org/r/121957/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for kwin.</div>
<div>By Elias Probst.</div>
<p style="color: grey;"><i>Updated Jan. 16, 2015, 9:54 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kwin
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Deprecate <code style="text-rendering: inherit;color: \
#4444cc;padding: 0;white-space: normal;margin: 0;line-height: \
inherit;">kservice_desktop_to_json()</code>, use <code style="text-rendering: \
inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: \
inherit;">kcoreaddons_desktop_to_json()</code> instead.</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Get \
rid of deprecation warnings in effects KCM.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Effects KCM still works as expected - all effects load \
and can be used.</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">Nearly all deprecation warnings \
regarding <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: \
normal;margin: 0;line-height: inherit;">kservice_desktop_to_json()</code> are gone \
now in effects KCM.</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">There's only one remaining:</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;"><div class="codehilite" style="background: #f8f8f8"><pre \
style="line-height: 125%">Constructing a KPluginInfo object from old style JSON. \
Please use kcoreaddons_desktop_to_json() <span style="color: #008000; font-weight: \
bold">for</span> <span style="color: \
#BA2121">"/usr/lib64/qt5/plugins/kwin/effects/configs/kcm_kwin4_genericscripted.so"</span> \
instead of kservice_desktop_to_json() in your CMake code. </pre></div>
</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">I couldn't find out so far why <code \
style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: \
0;line-height: inherit;">kcm_kwin4_genericscripted.so</code> is still processed using \
<code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: \
normal;margin: 0;line-height: inherit;">kservice_desktop_to_json()</code>.</p></pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>effects/blur/CMakeLists.txt <span style="color: \
grey">(afe5b65f134ce96cb3060fc8e9bdfbc5a990670f)</span></li>
<li>effects/coverswitch/CMakeLists.txt <span style="color: \
grey">(691faf43e5c9b0e43819ca08cb081f1c09119e83)</span></li>
<li>effects/cube/CMakeLists.txt <span style="color: \
grey">(2562689526d181e73fbbca26490611d06123a644)</span></li>
<li>effects/dashboard/CMakeLists.txt <span style="color: \
grey">(d55d16c21ef09f3be763a1ec534dabcf419834f2)</span></li>
<li>effects/desktopgrid/CMakeLists.txt <span style="color: \
grey">(4764374359060c932c4ce8b38f89cb919db5cfb0)</span></li>
<li>effects/diminactive/CMakeLists.txt <span style="color: \
grey">(221bc8fc0f4cd16f55d0d1bf3519f43919b139f8)</span></li>
<li>effects/flipswitch/CMakeLists.txt <span style="color: \
grey">(a0d011ea4be8911363df0ea30b317bbc32cbc924)</span></li>
<li>effects/glide/CMakeLists.txt <span style="color: \
grey">(9f8c47ffb74c657bcb86fd9829a150f2aac75867)</span></li>
<li>effects/invert/CMakeLists.txt <span style="color: \
grey">(9d637fb583ea4d5fa4c189b0f90f0f3ee72dbb56)</span></li>
<li>effects/lookingglass/CMakeLists.txt <span style="color: \
grey">(796697e494263fa8870d29fd1908306265733fa7)</span></li>
<li>effects/magiclamp/CMakeLists.txt <span style="color: \
grey">(5227f1ded8572ccf32eb64e1d171db5c30f6b7e2)</span></li>
<li>effects/magnifier/CMakeLists.txt <span style="color: \
grey">(6a43377176f810d0a7aba07a4c216d2d82a6b5c1)</span></li>
<li>effects/mouseclick/CMakeLists.txt <span style="color: \
grey">(251e8e744879634920c7ed93d6301fa8ef581eb2)</span></li>
<li>effects/mousemark/CMakeLists.txt <span style="color: \
grey">(71e20bad62e642b946faacc838bc4150e388bf82)</span></li>
<li>effects/presentwindows/CMakeLists.txt <span style="color: \
grey">(10e6a0b91cb745f8b384004c656bfea49fc20ab3)</span></li>
<li>effects/resize/CMakeLists.txt <span style="color: \
grey">(0f6b442a98db0eeb601858132e8124a1cb02b909)</span></li>
<li>effects/showfps/CMakeLists.txt <span style="color: \
grey">(c8de55ba1ca5405097d28a40171793d2a3bc5418)</span></li>
<li>effects/thumbnailaside/CMakeLists.txt <span style="color: \
grey">(8cd89a2fdae510157b7bff3f56032e6357c2a9f0)</span></li>
<li>effects/trackmouse/CMakeLists.txt <span style="color: \
grey">(3e68bea37b4f380f889cd9860e64997808b765da)</span></li>
<li>effects/windowgeometry/CMakeLists.txt <span style="color: \
grey">(bbf2fc691c021e050168f09fb7df51b5c1ae8944)</span></li>
<li>effects/wobblywindows/CMakeLists.txt <span style="color: \
grey">(a2db98fc2d8dcdd049f0c63d42168ae6ce9a3547)</span></li>
<li>effects/zoom/CMakeLists.txt <span style="color: \
grey">(7a86c08e4dcc2ca67c715db9efc1f14967bf8784)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/121957/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============1435747396848740663==--
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic