[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request 120881: [tabbox] Window Switcher layouts moved to kdeplasma-addons
From: Thomas_Lübking <thomas.luebking () gmail ! com>
Date: 2014-10-29 12:26:34
Message-ID: 20141029122634.23656.57914 () probe ! kde ! org
[Download RAW message or body]
--===============7849347653012532377==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
> On Okt. 29, 2014, 10:07 vorm., Thomas Lübking wrote:
> > i recall a crashbug on kf5 which occurred when a swtcher was configured, but none \
> > could be loaded (got to look out for the id) in case the code cannot be \
> > reasonably hardened otherwise, we might need to keep a failsafe. (but in either \
> > case will have to deal with that bug first, unless already fixed)
>
> Martin Gräßlin wrote:
> it should work:
> if (file.isNull()) {
> qDebug() << "Could not find QML file for window switcher";
> return nullptr;
> }
>
> given that code I'd expect that the code would support it. But yes, we should \
> clearly not crash if the switcher is missing. I'll verify by deleting the installed \
> switchers.
Found it, had fixed it ;-)
https://bugs.kde.org/show_bug.cgi?id=337853
- Thomas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120881/#review69398
-----------------------------------------------------------
On Okt. 29, 2014, 7:55 vorm., Martin Gräßlin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120881/
> -----------------------------------------------------------
>
> (Updated Okt. 29, 2014, 7:55 vorm.)
>
>
> Review request for kwin and Plasma.
>
>
> Repository: kwin
>
>
> Description
> -------
>
> [tabbox] Window Switcher layouts moved to kdeplasma-addons
>
>
> Diffs
> -----
>
> tabbox/qml/CMakeLists.txt e7d3b227eabf27622254ad8e50e97e6fcbec5c51
> tabbox/qml/IconTabBox.qml 589d3da7e2f7eb7c27912687c833c1c239c8b1ff
> tabbox/qml/clients/big_icons/contents/ui/main.qml \
> 74cef21ae0c782b432752477f3715994c73e459a \
> tabbox/qml/clients/big_icons/metadata.desktop \
> 1d13ad71d29b3a12161ffe023a2dbc6af69dbae8 \
> tabbox/qml/clients/compact/contents/ui/main.qml \
> c90959d62788e07f7da49782023f5df285d50988 \
> tabbox/qml/clients/compact/metadata.desktop \
> c96bfec03de451acdc9f4365c31bfb402851fcd4 \
> tabbox/qml/clients/informative/contents/ui/main.qml \
> e50dee6b4438eccee44129285be9ee61833cc15a \
> tabbox/qml/clients/informative/metadata.desktop \
> 6c8bd55e17aa7b5b5d792d11cab27dde0686efbf \
> tabbox/qml/clients/present_windows/contents/ui/main.qml \
> d9cd3a0168970f59f1efafe278f8c0a763ba42db \
> tabbox/qml/clients/present_windows/metadata.desktop \
> 298e5e0d5b135e70d8102feeca131bba341a73ea \
> tabbox/qml/clients/small_icons/contents/ui/main.qml \
> ec4a4d769e01c8f37db4af01911724f61934e496 \
> tabbox/qml/clients/small_icons/metadata.desktop \
> 01d5d74e0a1b2138ca2c3ad2c2f4483c51af40fa \
> tabbox/qml/clients/text/contents/ui/main.qml \
> 79f97c9559062b7bebab4311d97deb4a1c8ea17b tabbox/qml/clients/text/metadata.desktop \
> a0752b597edf6b18b8a985bff035240cbdeca06c \
> tabbox/qml/clients/thumbnails/contents/ui/main.qml \
> f70b3fc634fdb04651d8b843c5c290922dcb2c02 \
> tabbox/qml/clients/thumbnails/metadata.desktop \
> 7329bc8c47942c1841d63094286676de03ab7d6c
> Diff: https://git.reviewboard.kde.org/r/120881/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Martin Gräßlin
>
>
--===============7849347653012532377==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/120881/">https://git.reviewboard.kde.org/r/120881/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On Oktober 29th, 2014, 10:07 vorm. UTC, <b>Thomas \
Lübking</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">i recall a crashbug on kf5 which occurred when a \
swtcher was configured, but none could be loaded (got to look out for the id) in case \
the code cannot be reasonably hardened otherwise, we might need to keep a failsafe. \
(but in either case will have to deal with that bug first, unless already \
fixed)</p></pre> </blockquote>
<p>On Oktober 29th, 2014, 10:13 vorm. UTC, <b>Martin Gräßlin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">it \
should work: if (file.isNull()) {
qDebug() << "Could not find QML file for window switcher";
return nullptr;
}</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">given that code I'd expect that the code would support \
it. But yes, we should clearly not crash if the switcher is missing. I'll verify by \
deleting the installed switchers.</p></pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Found \
it, had fixed it ;-) https://bugs.kde.org/show_bug.cgi?id=337853</p></pre>
<br />
<p>- Thomas</p>
<br />
<p>On Oktober 29th, 2014, 7:55 vorm. UTC, Martin Gräßlin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for kwin and Plasma.</div>
<div>By Martin Gräßlin.</div>
<p style="color: grey;"><i>Updated Okt. 29, 2014, 7:55 vorm.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kwin
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">[tabbox] Window Switcher layouts moved to kdeplasma-addons</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>tabbox/qml/CMakeLists.txt <span style="color: \
grey">(e7d3b227eabf27622254ad8e50e97e6fcbec5c51)</span></li>
<li>tabbox/qml/IconTabBox.qml <span style="color: \
grey">(589d3da7e2f7eb7c27912687c833c1c239c8b1ff)</span></li>
<li>tabbox/qml/clients/big_icons/contents/ui/main.qml <span style="color: \
grey">(74cef21ae0c782b432752477f3715994c73e459a)</span></li>
<li>tabbox/qml/clients/big_icons/metadata.desktop <span style="color: \
grey">(1d13ad71d29b3a12161ffe023a2dbc6af69dbae8)</span></li>
<li>tabbox/qml/clients/compact/contents/ui/main.qml <span style="color: \
grey">(c90959d62788e07f7da49782023f5df285d50988)</span></li>
<li>tabbox/qml/clients/compact/metadata.desktop <span style="color: \
grey">(c96bfec03de451acdc9f4365c31bfb402851fcd4)</span></li>
<li>tabbox/qml/clients/informative/contents/ui/main.qml <span style="color: \
grey">(e50dee6b4438eccee44129285be9ee61833cc15a)</span></li>
<li>tabbox/qml/clients/informative/metadata.desktop <span style="color: \
grey">(6c8bd55e17aa7b5b5d792d11cab27dde0686efbf)</span></li>
<li>tabbox/qml/clients/present_windows/contents/ui/main.qml <span style="color: \
grey">(d9cd3a0168970f59f1efafe278f8c0a763ba42db)</span></li>
<li>tabbox/qml/clients/present_windows/metadata.desktop <span style="color: \
grey">(298e5e0d5b135e70d8102feeca131bba341a73ea)</span></li>
<li>tabbox/qml/clients/small_icons/contents/ui/main.qml <span style="color: \
grey">(ec4a4d769e01c8f37db4af01911724f61934e496)</span></li>
<li>tabbox/qml/clients/small_icons/metadata.desktop <span style="color: \
grey">(01d5d74e0a1b2138ca2c3ad2c2f4483c51af40fa)</span></li>
<li>tabbox/qml/clients/text/contents/ui/main.qml <span style="color: \
grey">(79f97c9559062b7bebab4311d97deb4a1c8ea17b)</span></li>
<li>tabbox/qml/clients/text/metadata.desktop <span style="color: \
grey">(a0752b597edf6b18b8a985bff035240cbdeca06c)</span></li>
<li>tabbox/qml/clients/thumbnails/contents/ui/main.qml <span style="color: \
grey">(f70b3fc634fdb04651d8b843c5c290922dcb2c02)</span></li>
<li>tabbox/qml/clients/thumbnails/metadata.desktop <span style="color: \
grey">(7329bc8c47942c1841d63094286676de03ab7d6c)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/120881/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============7849347653012532377==--
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic