[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request 120849: [tabbox] Try locating the WindowSwitcher QML through configured lnf packa
From: Thomas_Lübking <thomas.luebking () gmail ! com>
Date: 2014-10-28 22:15:47
Message-ID: 20141028221547.23655.6392 () probe ! kde ! org
[Download RAW message or body]
--===============5600731813638986880==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120849/#review69364
-----------------------------------------------------------
Ship it!
Lol, the patch looks pretty scary compared to the actual change.
tabbox/tabboxhandler.cpp
<https://git.reviewboard.kde.org/r/120849/#comment48480>
why not? (by different name, oc)
- Thomas Lübking
On Okt. 28, 2014, 3:53 nachm., Martin Gräßlin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120849/
> -----------------------------------------------------------
>
> (Updated Okt. 28, 2014, 3:53 nachm.)
>
>
> Review request for kwin and Plasma.
>
>
> Repository: kwin
>
>
> Description
> -------
>
> We assume the configured layout name is a look and feel package. Thus
> the Switcher is located at contents/windowswitcher/WindowSwitcher.qml
> of that package.
>
>
> Diffs
> -----
>
> tabbox/tabboxconfig.h f953102986b2d5577cc89321e7fecdea336bfc07
> tabbox/tabboxhandler.cpp cae64e3aec31af223a51fa4126798c736df411f1
>
> Diff: https://git.reviewboard.kde.org/r/120849/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Martin Gräßlin
>
>
--===============5600731813638986880==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/120849/">https://git.reviewboard.kde.org/r/120849/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Lol, \
the patch looks pretty scary compared to the actual change.</p></pre> <br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/120849/diff/1/?file=322492#file322492line235" \
style="color: black; font-weight: bold; text-decoration: \
underline;">tabbox/tabboxhandler.cpp</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
TabBoxHandlerPrivate::endHighlightWindows(bool abort)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">235</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">QString</span> <span class="n">constraint</span> <span class="o">=</span> \
<span class="n">QStringLiteral</span><span class="p">(</span><span \
class="s">"[X-KDE-PluginInfo-Name] == '%1'"</span><span \
class="p">).</span><span class="n">arg</span><span class="p">(</span><span \
class="n">config</span><span class="p">.</span><span class="n">layoutName</span><span \
class="p">());</span></pre></td> <th bgcolor="#e9eaa8" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">235</font></th> <td bgcolor="#fdfebc" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "> <span class="k">if</span> <span \
class="p">(</span><span class="o">!</span><span class="n">desktopMode</span><span \
class="p">)</span> <span class="p">{</span></pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">why \
not? (by different name, oc)</p></pre> </div>
</div>
<br />
<p>- Thomas Lübking</p>
<br />
<p>On Oktober 28th, 2014, 3:53 nachm. UTC, Martin Gräßlin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for kwin and Plasma.</div>
<div>By Martin Gräßlin.</div>
<p style="color: grey;"><i>Updated Okt. 28, 2014, 3:53 nachm.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kwin
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">We assume the configured layout name is a look and feel package. Thus \
the Switcher is located at contents/windowswitcher/WindowSwitcher.qml of that \
package.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>tabbox/tabboxconfig.h <span style="color: \
grey">(f953102986b2d5577cc89321e7fecdea336bfc07)</span></li>
<li>tabbox/tabboxhandler.cpp <span style="color: \
grey">(cae64e3aec31af223a51fa4126798c736df411f1)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/120849/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============5600731813638986880==--
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic