'Re: Review Request 118765: WORKAROUND bug #335926'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Re: Review Request 118765: WORKAROUND bug #335926
From:       "Commit Hook" <null () kde ! org>
Date:       2014-07-03 17:06:07
Message-ID: 20140703170607.18466.62679 () probe ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118765/#review61569
-----------------------------------------------------------

This review has been submitted with commit c654dd4ff12beb6941394b1e5530c846a1378f1d \
by Thomas Lübking to branch master.

- Commit Hook

On June 30, 2014, 8:32 p.m., Thomas Lübking wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118765/
> -----------------------------------------------------------
> 
> (Updated June 30, 2014, 8:32 p.m.)
> 
> 
> Review request for kwin and Martin Gräßlin.
> 
> 
> Bugs: 335926
> https://bugs.kde.org/show_bug.cgi?id=335926
> 
> 
> Repository: kwin
> 
> 
> Description
> -------
> 
> commit 07cd9d20e498e615a4fd7d84ac2fb18f6fe7c55d
> WORKAROUND bug #335926
> 
> QXcbScreen overrides the input eventmask when
> adding a screen, so we claim our stuff back
> 
> BUG: 335926
> 
> commit 937e8b391d4c5bb67a69d5429426c8f139796538
> add selectWmInputEventMask function
> 
> It sets the mask required for a WM and in addition
> preserves the eventmask present on the root window for
> this client (as set by any lib etc.)
> 
> 
> Diffs
> -----
> 
> workspace.h 6c76006 
> workspace.cpp 0e17bb0 
> 
> Diff: https://git.reviewboard.kde.org/r/118765/diff/
> 
> 
> Testing
> -------
> 
> yupp
> 
> 
> Thanks,
> 
> Thomas Lübking
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/118765/">https://git.reviewboard.kde.org/r/118765/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit c654dd4ff12beb6941394b1e5530c846a1378f1d by Thomas Lübking to \
branch master.</pre>  <br />

<p>- Commit Hook</p>

<br />
<p>On June 30th, 2014, 8:32 p.m. UTC, Thomas Lübking wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kwin and Martin Gräßlin.</div>
<div>By Thomas Lübking.</div>

<p style="color: grey;"><i>Updated June 30, 2014, 8:32 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="https://bugs.kde.org/show_bug.cgi?id=335926">335926</a>

</div>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kwin
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">commit 07cd9d20e498e615a4fd7d84ac2fb18f6fe7c55d  WORKAROUND bug #335926

    QXcbScreen overrides the input eventmask when
    adding a screen, so we claim our stuff back

    BUG: 335926

commit 937e8b391d4c5bb67a69d5429426c8f139796538
    add selectWmInputEventMask function

    It sets the mask required for a WM and in addition
    preserves the eventmask present on the root window for
    this client (as set by any lib etc.)</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">yupp</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>workspace.h <span style="color: grey">(6c76006)</span></li>

 <li>workspace.cpp <span style="color: grey">(0e17bb0)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/118765/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin

[prev in list] [next in list] [prev in thread] [next in thread] 