'Re: Review Request 118252: Port KWindowSystem::minimizeWindow and unminizeWindow to XCB'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    Re: Review Request 118252: Port KWindowSystem::minimizeWindow and unminizeWindow to XCB
From:       "Kevin Ottens" <ervin () kde ! org>
Date:       2014-06-16 9:34:09
Message-ID: 20140616093409.3734.98614 () probe ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118252/#review60175
-----------------------------------------------------------

Ship it!

Ship It!

- Kevin Ottens

On May 26, 2014, 7:09 a.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118252/
> -----------------------------------------------------------
> 
> (Updated May 26, 2014, 7:09 a.m.)
> 
> 
> Review request for KDE Frameworks, kwin and Eike Hein.
> 
> 
> Repository: kwindowsystem
> 
> 
> Description
> -------
> 
> Port KWindowSystem::minimizeWindow and unminizeWindow to XCB
> 
> Unit test added to verify that the functionality works correctly.
> 
> Note: it uses an Atom instead of xcb_atom_t for WM_CHANGE_STATE as the
> create_atoms() function is not yet ported to xcb.
> 
> 
> Diffs
> -----
> 
>   autotests/kwindowsystemx11test.cpp ec6a574691fd25dde7d02da619cd497bc3660210 
>   src/kwindowsystem_x11.cpp 74370cb96229a3042fbfd061ae442b5cf2b403e9 
> 
> Diff: https://git.reviewboard.kde.org/r/118252/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/118252/">https://git.reviewboard.kde.org/r/118252/</a>
  </td>
    </tr>
   </table>
   <br />

 <p>Ship it!</p>

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre>  <br />

<p>- Kevin Ottens</p>

<br />
<p>On May 26th, 2014, 7:09 a.m. UTC, Martin Gräßlin wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for KDE Frameworks, kwin and Eike Hein.</div>
<div>By Martin Gräßlin.</div>

<p style="color: grey;"><i>Updated May 26, 2014, 7:09 a.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kwindowsystem
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Port KWindowSystem::minimizeWindow and unminizeWindow to XCB

Unit test added to verify that the functionality works correctly.

Note: it uses an Atom instead of xcb_atom_t for WM_CHANGE_STATE as the
create_atoms() function is not yet ported to xcb.</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>autotests/kwindowsystemx11test.cpp <span style="color: \
grey">(ec6a574691fd25dde7d02da619cd497bc3660210)</span></li>

 <li>src/kwindowsystem_x11.cpp <span style="color: \
grey">(74370cb96229a3042fbfd061ae442b5cf2b403e9)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/118252/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

[prev in list] [next in list] [prev in thread] [next in thread] 