'Re: Review Request 118414: [killer] Use dialog-warning icon as window icon for killer'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Re: Review Request 118414: [killer] Use dialog-warning icon as window icon for killer
From:       "Commit Hook" <null () kde ! org>
Date:       2014-06-02 13:02:33
Message-ID: 20140602130233.31339.38408 () probe ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118414/#review58960
-----------------------------------------------------------

This review has been submitted with commit dc37805586fdb0f061e1949dc4e26cc6f6699077 \
by Martin Gräßlin to branch master.

- Commit Hook

On May 30, 2014, 6:54 a.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118414/
> -----------------------------------------------------------
> 
> (Updated May 30, 2014, 6:54 a.m.)
> 
> 
> Review request for kwin and Plasma.
> 
> 
> Repository: kwin
> 
> 
> Description
> -------
> 
> [killer] Use dialog-warning icon as window icon for killer
> 
> Based on the discussion on kwin [1] and plasma-devel [2] mailing list.
> 
> [1] http://lists.kde.org/?l=kwin&m=140119827404150&w=2
> [2] https://mail.kde.org/pipermail/plasma-devel/2014-May/031749.html
> 
> 
> Diffs
> -----
> 
> killer/killer.cpp 0c3ca043ecf9dcd14813dc8d2c8cca8254e51a25 
> 
> Diff: https://git.reviewboard.kde.org/r/118414/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> Killer with warning icon
> https://git.reviewboard.kde.org/media/uploaded/files/2014/05/30/49819e8e-d86c-48e9-8829-c01ba90cad9a__killer-window-warning.png
>  
> 
> Thanks,
> 
> Martin Gräßlin
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/118414/">https://git.reviewboard.kde.org/r/118414/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit dc37805586fdb0f061e1949dc4e26cc6f6699077 by Martin Gräßlin to \
branch master.</pre>  <br />

<p>- Commit Hook</p>

<br />
<p>On May 30th, 2014, 6:54 a.m. UTC, Martin Gräßlin wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kwin and Plasma.</div>
<div>By Martin Gräßlin.</div>

<p style="color: grey;"><i>Updated May 30, 2014, 6:54 a.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kwin
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">[killer] Use dialog-warning icon as window icon for killer

Based on the discussion on kwin [1] and plasma-devel [2] mailing list.

[1] http://lists.kde.org/?l=kwin&amp;m=140119827404150&amp;w=2
[2] https://mail.kde.org/pipermail/plasma-devel/2014-May/031749.html</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>killer/killer.cpp <span style="color: \
grey">(0c3ca043ecf9dcd14813dc8d2c8cca8254e51a25)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/118414/diff/" style="margin-left: \
3em;">View Diff</a></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>

<ul>

 <li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/05/30/49819e8e-d86c-48e9-8829-c01ba90cad9a__killer-window-warning.png">Killer \
with warning icon</a></li>

</ul>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin

[prev in list] [next in list] [prev in thread] [next in thread] 