'Re: Review Request 115930: Use KPluginLoader to load our decoration plugins'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Re: Review Request 115930: Use KPluginLoader to load our decoration plugins
From:       Sebastian_Kügler <sebas () kde ! org>
Date:       2014-02-27 14:41:01
Message-ID: 20140227144101.20355.58174 () probe ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115930/#review51062
-----------------------------------------------------------

Looks good from my point of view.

- Sebastian Kügler

On Feb. 24, 2014, 9:27 a.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115930/
> -----------------------------------------------------------
> 
> (Updated Feb. 24, 2014, 9:27 a.m.)
> 
> 
> Review request for kwin and Sebastian Kügler.
> 
> 
> Repository: kde-workspace
> 
> 
> Description
> -------
> 
> Use KPluginLoader to load our decoration plugins
> 
> This simplifies the plugin loading. Decorations just have to use
> K_PLUGIN_FACTORY to specify how the KDecorationFactory needs to be
> created. The KWIN_DECORATION macro is adjusted to generate the
> boiler plate code, but it now needs to specify the name for the
> pluginfactory and the KDecorationFactory.
> 
> This also transits the decoration abi version check to use
> K_EXPORT_PLUGIN_VERSION which also simplifies the loading.
> 
> As a result the complete canLoad handling in DecorationPlugins is
> removed.
> 
> 
> Diffs
> -----
> 
>   kwin/clients/aurorae/src/aurorae.h 1d105bd6b7cdacd0ec66a6f340b517cb85e2be13 
>   kwin/clients/aurorae/src/aurorae.cpp 76ec176bbce865a2c7b369c8c77c48f93c296cde 
>   kwin/clients/oxygen/CMakeLists.txt d4ac9ea010716800f0a36b70f9250066c9cb1553 
>   kwin/clients/oxygen/oxygenfactory.cpp 6d5b08b9160a7794f668feb2914450b602360ce6 
>   kwin/kcmkwin/kwindecoration/decorationmodel.cpp 351e47013b53a4b4b0b023ca3cf11914fa28a416 
>   kwin/libkdecorations/kdecoration.h 99ece35033e20c8adae257b49d585d6f07df6360 
>   kwin/libkdecorations/kdecoration_plugins_p.h bf36fc4860be5df418a5657f7247ef90f8eb5ca8 
>   kwin/libkdecorations/kdecoration_plugins_p.cpp 49254e0e5cbd1460e9a2f1bcca343e261b44690d 
> 
> Diff: https://git.reviewboard.kde.org/r/115930/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/115930/">https://git.reviewboard.kde.org/r/115930/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looks good from my point \
of view.</pre>  <br />

<p>- Sebastian Kügler</p>

<br />
<p>On February 24th, 2014, 9:27 a.m. UTC, Martin Gräßlin wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kwin and Sebastian Kügler.</div>
<div>By Martin Gräßlin.</div>

<p style="color: grey;"><i>Updated Feb. 24, 2014, 9:27 a.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-workspace
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Use KPluginLoader to load our decoration plugins

This simplifies the plugin loading. Decorations just have to use
K_PLUGIN_FACTORY to specify how the KDecorationFactory needs to be
created. The KWIN_DECORATION macro is adjusted to generate the
boiler plate code, but it now needs to specify the name for the
pluginfactory and the KDecorationFactory.

This also transits the decoration abi version check to use
K_EXPORT_PLUGIN_VERSION which also simplifies the loading.

As a result the complete canLoad handling in DecorationPlugins is
removed.</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kwin/clients/aurorae/src/aurorae.h <span style="color: \
grey">(1d105bd6b7cdacd0ec66a6f340b517cb85e2be13)</span></li>

 <li>kwin/clients/aurorae/src/aurorae.cpp <span style="color: \
grey">(76ec176bbce865a2c7b369c8c77c48f93c296cde)</span></li>

 <li>kwin/clients/oxygen/CMakeLists.txt <span style="color: \
grey">(d4ac9ea010716800f0a36b70f9250066c9cb1553)</span></li>

 <li>kwin/clients/oxygen/oxygenfactory.cpp <span style="color: \
grey">(6d5b08b9160a7794f668feb2914450b602360ce6)</span></li>

 <li>kwin/kcmkwin/kwindecoration/decorationmodel.cpp <span style="color: \
grey">(351e47013b53a4b4b0b023ca3cf11914fa28a416)</span></li>

 <li>kwin/libkdecorations/kdecoration.h <span style="color: \
grey">(99ece35033e20c8adae257b49d585d6f07df6360)</span></li>

 <li>kwin/libkdecorations/kdecoration_plugins_p.h <span style="color: \
grey">(bf36fc4860be5df418a5657f7247ef90f8eb5ca8)</span></li>

 <li>kwin/libkdecorations/kdecoration_plugins_p.cpp <span style="color: \
grey">(49254e0e5cbd1460e9a2f1bcca343e261b44690d)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/115930/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin

[prev in list] [next in list] [prev in thread] [next in thread] 