'Re: Review Request 116076: Hide the OnAllDesktops button if there is only one virtual desktop'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Re: Review Request 116076: Hide the OnAllDesktops button if there is only one virtual desktop
From:       Martin_Gräßlin <mgraesslin () kde ! org>
Date:       2014-02-27 10:08:34
Message-ID: 20140227100834.20355.71493 () probe ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116076/
-----------------------------------------------------------

(Updated Feb. 27, 2014, 11:08 a.m.)

Review request for kwin.

Changes
-------

Changed to bridge

Bugs: 321611
    http://bugs.kde.org/show_bug.cgi?id=321611

Repository: kde-workspace

Description
-------

Hide the OnAllDesktops button if there is only one virtual desktop

In KCommonDecoration the OnAllDesktops button gets hidden or shown
depending on the number of desktops. For that KCommonDecoration
connects to the numberOfDesktopsChanged signal from KWindowSystem.

Diffs (updated)
-----

  kwin/bridge.h 56da28753613d8116e697dfbc1d434d27fd358c6 
  kwin/bridge.cpp e352d577cab75270f2c157b5a591c9c060d8d377 
  kwin/client.h a8ab0027bd7099c135021cd881633a8d75a318e5 
  kwin/client.cpp 023419254b62dd9f0377b63621428047b2d4ade8 
  kwin/kcmkwin/kwindecoration/preview.h 05404fb354bee74c38dc62ef3fa5349475ff9f55 
  kwin/kcmkwin/kwindecoration/preview.cpp 12eef4a0d49a34dfabb15a3c3cf2c8269338cda5 
  kwin/libkdecorations/kcommondecoration.cpp bf25488febf47660eb0a168eac577f347a34359c 
  kwin/libkdecorations/kdecoration.h 99ece35033e20c8adae257b49d585d6f07df6360 
  kwin/libkdecorations/kdecoration.cpp a0ac761d5aaa141d58b22f3db6646d0154487379 
  kwin/libkdecorations/kdecorationbridge.h 0b58d6de0e597e555c84286c428c70568d59618a 

Diff: https://git.reviewboard.kde.org/r/116076/diff/

Testing
-------

Thanks,

Martin Gräßlin

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/116076/">https://git.reviewboard.kde.org/r/116076/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kwin.</div>
<div>By Martin Gräßlin.</div>

<p style="color: grey;"><i>Updated Feb. 27, 2014, 11:08 a.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Changed to bridge</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=321611">321611</a>

</div>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-workspace
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Hide the OnAllDesktops button if there is only one virtual desktop

In KCommonDecoration the OnAllDesktops button gets hidden or shown
depending on the number of desktops. For that KCommonDecoration
connects to the numberOfDesktopsChanged signal from KWindowSystem.</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>kwin/bridge.h <span style="color: \
grey">(56da28753613d8116e697dfbc1d434d27fd358c6)</span></li>

 <li>kwin/bridge.cpp <span style="color: \
grey">(e352d577cab75270f2c157b5a591c9c060d8d377)</span></li>

 <li>kwin/client.h <span style="color: \
grey">(a8ab0027bd7099c135021cd881633a8d75a318e5)</span></li>

 <li>kwin/client.cpp <span style="color: \
grey">(023419254b62dd9f0377b63621428047b2d4ade8)</span></li>

 <li>kwin/kcmkwin/kwindecoration/preview.h <span style="color: \
grey">(05404fb354bee74c38dc62ef3fa5349475ff9f55)</span></li>

 <li>kwin/kcmkwin/kwindecoration/preview.cpp <span style="color: \
grey">(12eef4a0d49a34dfabb15a3c3cf2c8269338cda5)</span></li>

 <li>kwin/libkdecorations/kcommondecoration.cpp <span style="color: \
grey">(bf25488febf47660eb0a168eac577f347a34359c)</span></li>

 <li>kwin/libkdecorations/kdecoration.h <span style="color: \
grey">(99ece35033e20c8adae257b49d585d6f07df6360)</span></li>

 <li>kwin/libkdecorations/kdecoration.cpp <span style="color: \
grey">(a0ac761d5aaa141d58b22f3db6646d0154487379)</span></li>

 <li>kwin/libkdecorations/kdecorationbridge.h <span style="color: \
grey">(0b58d6de0e597e555c84286c428c70568d59618a)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/116076/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin

[prev in list] [next in list] [prev in thread] [next in thread] 