[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request 115910: Screenedge show support for Clients
From: Martin_Gräßlin <mgraesslin () kde ! org>
Date: 2014-02-21 7:19:02
Message-ID: 20140221071902.27042.9441 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Feb. 20, 2014, 5:59 p.m., Thomas Lübking wrote:
> > kwin/screenedge.cpp, line 170
> > <https://git.reviewboard.kde.org/r/115910/diff/1/?file=245042#file245042line170>
> >
> > what happens if two clients reserve overlapping geometry?
> > One will be fired, the edge hidden, the cursor enters the edge of the other one \
> > and that fires as well? Should the ranged be made exclusive (ie. the overlapping \
> > area is given half to the one and half the other client?)
>
> Martin Gräßlin wrote:
> I haven't tested it with multiple clients but I do hope that I got it correct: they \
> should all fire. Also normal actions should fire. That's in fact something i tried, \
> like do the corners still activate if there's also the window.
just tested, works as intended: it fires for all clients and actions
- Martin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115910/#review50385
-----------------------------------------------------------
On Feb. 20, 2014, 2:51 p.m., Martin Gräßlin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115910/
> -----------------------------------------------------------
>
> (Updated Feb. 20, 2014, 2:51 p.m.)
>
>
> Review request for kwin and Plasma.
>
>
> Repository: kde-workspace
>
>
> Description
> -------
>
> Screenedge show support for Clients
>
> This provides a new protocol intended to be used by auto-hiding panels
> to make use of the centralized screen edges. To use it a Client can
> send a client message of type _KDE_NET_WM_SCREEN_EDGE_SHOW to KWin.
> KWin will hide the Client (hide because unmap or minimize would break
> it) and create an Edge. If that Edge gets triggered the Client is shown
> again. If the Client doesn't border a screen edge the Client gets shown
> immediately so that we never end in a situation that we cannot unhide
> the auto-hidden panel again. The exact process is described in the
> documentation of ScreenEdges.
>
> If KWin gets restarted the Client gets shown again.
>
> As this is a KWin specific extension we need to discuss what it means
> for Clients using this feature with other WMs: it does nothing. As
> the Client gets hidden by KWin and not by the Client, it just doesn't
> get hidden if the WM doesn't provide the feature. In case of an
> auto-hiding panel this seems like a good solution given that we don't
> want to hide it if we cannot unhide it. Of course there's the option
> for the Client to provide that feature itself and if that's wanted we
> would need to announce the feature in the _NET_SUPPORTED atom. At the
> moment that doesn't sound like being needed as Plasma doesn't want to
> provide an own implementation.
>
> The implementation comes with a small test application showing how
> the feature is intended to be used.
>
>
> Diffs
> -----
>
> kwin/atoms.h 1690067c5d1da59f38f9e77ef64eacfbc1faa0cf
> kwin/atoms.cpp 904f5efe4a32e3673dae9e6da92bf4336def660d
> kwin/client.cpp 36431bfc33418a207de12fa8cc95a35539256366
> kwin/events.cpp 1fa6e425d4dac7d661612e5d090c3c9c8f4b1a18
> kwin/screenedge.h 60f5fd669ccc5eb627feffa460552558d1765b31
> kwin/screenedge.cpp 04cf0d6d5262ab84d88559b6dc85e099efec77bf
> kwin/tests/CMakeLists.txt 3fa16f21c617a8f4b39b2bbd39b534b6a11e8d14
> kwin/tests/screenedgeshowtest.cpp PRE-CREATION
>
> Diff: https://git.reviewboard.kde.org/r/115910/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Martin Gräßlin
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/115910/">https://git.reviewboard.kde.org/r/115910/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On February 20th, 2014, 5:59 p.m. CET, <b>Thomas \
Lübking</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/115910/diff/1/?file=245042#file245042line170" \
style="color: black; font-weight: bold; text-decoration: \
underline;">kwin/screenedge.cpp</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">bool \
Edge::canActivate(const QPoint &cursorPos, const QDateTime \
&triggerTime)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">170</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">unreserve</span><span class="p">();</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">what happens if two \
clients reserve overlapping geometry? One will be fired, the edge hidden, the cursor \
enters the edge of the other one and that fires as well? Should the ranged be made \
exclusive (ie. the overlapping area is given half to the one and half the other \
client?)</pre> </blockquote>
<p>On February 20th, 2014, 7:25 p.m. CET, <b>Martin Gräßlin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I haven't tested it \
with multiple clients but I do hope that I got it correct: they should all fire. Also \
normal actions should fire. That's in fact something i tried, like do the corners \
still activate if there's also the window.</pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">just \
tested, works as intended: it fires for all clients and actions</pre> <br />
<p>- Martin</p>
<br />
<p>On February 20th, 2014, 2:51 p.m. CET, Martin Gräßlin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin and Plasma.</div>
<div>By Martin Gräßlin.</div>
<p style="color: grey;"><i>Updated Feb. 20, 2014, 2:51 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Screenedge show support for Clients
This provides a new protocol intended to be used by auto-hiding panels
to make use of the centralized screen edges. To use it a Client can
send a client message of type _KDE_NET_WM_SCREEN_EDGE_SHOW to KWin.
KWin will hide the Client (hide because unmap or minimize would break
it) and create an Edge. If that Edge gets triggered the Client is shown
again. If the Client doesn't border a screen edge the Client gets shown
immediately so that we never end in a situation that we cannot unhide
the auto-hidden panel again. The exact process is described in the
documentation of ScreenEdges.
If KWin gets restarted the Client gets shown again.
As this is a KWin specific extension we need to discuss what it means
for Clients using this feature with other WMs: it does nothing. As
the Client gets hidden by KWin and not by the Client, it just doesn't
get hidden if the WM doesn't provide the feature. In case of an
auto-hiding panel this seems like a good solution given that we don't
want to hide it if we cannot unhide it. Of course there's the option
for the Client to provide that feature itself and if that's wanted we
would need to announce the feature in the _NET_SUPPORTED atom. At the
moment that doesn't sound like being needed as Plasma doesn't want to
provide an own implementation.
The implementation comes with a small test application showing how
the feature is intended to be used.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/atoms.h <span style="color: \
grey">(1690067c5d1da59f38f9e77ef64eacfbc1faa0cf)</span></li>
<li>kwin/atoms.cpp <span style="color: \
grey">(904f5efe4a32e3673dae9e6da92bf4336def660d)</span></li>
<li>kwin/client.cpp <span style="color: \
grey">(36431bfc33418a207de12fa8cc95a35539256366)</span></li>
<li>kwin/events.cpp <span style="color: \
grey">(1fa6e425d4dac7d661612e5d090c3c9c8f4b1a18)</span></li>
<li>kwin/screenedge.h <span style="color: \
grey">(60f5fd669ccc5eb627feffa460552558d1765b31)</span></li>
<li>kwin/screenedge.cpp <span style="color: \
grey">(04cf0d6d5262ab84d88559b6dc85e099efec77bf)</span></li>
<li>kwin/tests/CMakeLists.txt <span style="color: \
grey">(3fa16f21c617a8f4b39b2bbd39b534b6a11e8d14)</span></li>
<li>kwin/tests/screenedgeshowtest.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/115910/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic