This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115389/

This change has been marked as submitted.


Review request for kwin and Martin Gräßlin.
By Thomas Lübking.

Updated Jan. 30, 2014, 7:44 p.m.

Bugs: 328010
Repository: kde-workspace

Description

let's turn this into a proper request ;-)

counter suggest was

void MouseClickEffect::slotMouseChanged(...)
{
if (!m_enabled) return;
...

objection against this was:
mouse polling is fired pretty often, so why bind the slot just to exit it on invocation (most of the time)?

Diffs

  • kwin/effects/mouseclick/mouseclick.cpp (99b9303)

View Diff