From kwin Thu Jan 30 19:44:36 2014 From: =?utf-8?q?Thomas_L=C3=BCbking?= Date: Thu, 30 Jan 2014 19:44:36 +0000 To: kwin Subject: Re: Review Request 115389: mouseclick effect, do not collect clicks while not active Message-Id: <20140130194436.23515.96916 () probe ! kde ! org> X-MARC-Message: https://marc.info/?l=kwin&m=139111110207615 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============9195172992568779289==" --===============9195172992568779289== Content-Type: multipart/alternative; boundary="===============1034925942053618627==" --===============1034925942053618627== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115389/ ----------------------------------------------------------- (Updated Jan. 30, 2014, 7:44 p.m.) Status ------ This change has been marked as submitted. Review request for kwin and Martin Gräßlin. Bugs: 328010 http://bugs.kde.org/show_bug.cgi?id=328010 Repository: kde-workspace Description ------- let's turn this into a proper request ;-) counter suggest was void MouseClickEffect::slotMouseChanged(...) { if (!m_enabled) return; ... objection against this was: mouse polling is fired pretty often, so why bind the slot just to exit it on invocation (most of the time)? Diffs ----- kwin/effects/mouseclick/mouseclick.cpp 99b9303 Diff: https://git.reviewboard.kde.org/r/115389/diff/ Testing ------- Thanks, Thomas Lübking --===============1034925942053618627== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115389/

This change has been marked as submitted.

Review request for kwin and Martin Gräßlin.

By Thomas Lübking.

Updated Jan. 30, 2014, 7:44 p.m.

Bugs: 328010

Repository: kde-workspace

Description

let's turn this into a proper request ;-)

counter suggest was

void MouseClickEffect::slotMouseChanged(...)
{
if (!m_enabled) return;
...

objection against this was:
mouse polling is fired pretty often, so why bind the slot just to exit it on invocation (most of the time)?

Diffs

kwin/effects/mouseclick/mouseclick.cpp (99b9303)

View Diff

--===============1034925942053618627==-- --===============9195172992568779289== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ kwin mailing list kwin@kde.org https://mail.kde.org/mailman/listinfo/kwin --===============9195172992568779289==--